# Re: \[RFC PATCH for 4.21 04/16\] mm: Introduce vm\_map\_user\_ram, vm\_unmap\_user\_ram

- From: Sergey Senozhatsky \<hidden\>
- Date: 2018-10-17 15:34:24 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2018/10/5410920
- Thread: https://ratatoskr.run/linux-api/2018/10/5404697/t.md

```text
On (10/17/18 11:04), Mathieu Desnoyers wrote:
> >> 
> >>> 	if (WARN_ON(x))
> >>> 		return;
> >> 
> >> Given that this somewhat MM-related, I'd may be say VM_WARN_ON().
> 
> I notice that VM_WARN_ON() casts the result of WARN_ON() to (void), so it
> cannot be used in a if () statement.
> 
> VM_WARN_ON() will only warn if CONFIG_DEBUG_VM is set.
> 
> Is it really what we want ?

Oh, indeed... Sorry, I forgot that they cast WANR_ON() return to void.
Let's do what Steven suggested.

	-ss
```
