Patch "fs/proc: Report eip/esp in /prod/PID/stat for coredumping" has been added to the 4.9-stable tree
From: <hidden>
Date: 2017-09-28 13:34:38
Also in:
stable
This is a note to let you know that I've just added the patch titled
fs/proc: Report eip/esp in /prod/PID/stat for coredumping
to the 4.9-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
fs-proc-report-eip-esp-in-prod-pid-stat-for-coredumping.patch
and it can be found in the queue-4.9 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let [off-list ref] know about it.
From fd7d56270b526ca3ed0c224362e3c64a0f86687a Mon Sep 17 00:00:00 2001
From: John Ogness <redacted>
Date: Thu, 14 Sep 2017 11:42:17 +0200
Subject: fs/proc: Report eip/esp in /prod/PID/stat for coredumping
From: John Ogness <redacted>
commit fd7d56270b526ca3ed0c224362e3c64a0f86687a upstream.
Commit 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in
/proc/PID/stat") stopped reporting eip/esp because it is
racy and dangerous for executing tasks. The comment adds:
As far as I know, there are no use programs that make any
material use of these fields, so just get rid of them.
However, existing userspace core-dump-handler applications (for
example, minicoredumper) are using these fields since they
provide an excellent cross-platform interface to these valuable
pointers. So that commit introduced a user space visible
regression.
Partially revert the change and make the readout possible for
tasks with the proper permissions and only if the target task
has the PF_DUMPCORE flag set.
Fixes: 0a1eb2d474ed ("fs/proc: Stop reporting eip and esp in> /proc/PID/stat")
Reported-by: Marco Felsch <redacted>
Signed-off-by: John Ogness <redacted>
Reviewed-by: Andy Lutomirski <redacted>
Cc: Tycho Andersen <redacted>
Cc: Kees Cook <redacted>
Cc: Peter Zijlstra <redacted>
Cc: Brian Gerst <redacted>
Cc: Tetsuo Handa <penguin-kernel-1yMVhJb1mP/7nzcFbJAaVXf5DAMn2ifp@public.gmane.org>
Cc: Borislav Petkov <redacted>
Cc: Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
Cc: Linux API <redacted>
Cc: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Cc: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Link: http://lkml.kernel.org/r/87poatfwg6.fsf-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org
Signed-off-by: Thomas Gleixner <redacted>
Signed-off-by: Greg Kroah-Hartman <redacted>
---
fs/proc/array.c | 9 +++++++++
1 file changed, 9 insertions(+)
--- a/fs/proc/array.c
+++ b/fs/proc/array.c@@ -60,6 +60,7 @@ #include <linux/tty.h> #include <linux/string.h> #include <linux/mman.h> +#include <linux/sched.h> #include <linux/proc_fs.h> #include <linux/ioport.h> #include <linux/uaccess.h>
@@ -416,7 +417,15 @@ static int do_task_stat(struct seq_file * esp and eip are intentionally zeroed out. There is no * non-racy way to read them without freezing the task. * Programs that need reliable values can use ptrace(2). + * + * The only exception is if the task is core dumping because + * a program is not able to use ptrace(2) in that case. It is + * safe because the task has stopped executing permanently. */ + if (permitted && (task->flags & PF_DUMPCORE)) { + eip = KSTK_EIP(task); + esp = KSTK_ESP(task); + } } get_task_comm(tcomm, task);
Patches currently in stable-queue which might be from john.ogness-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org are queue-4.9/fs-proc-report-eip-esp-in-prod-pid-stat-for-coredumping.patch