# Re: \[PATCH 8/8\] signal: Remove kernel interal si\_code magic

- List: linux-api
- 1 message, 1 author
- Page: https://ratatoskr.run/linux-api/2017/07/5041465/t

## Re: \[PATCH 8/8\] signal: Remove kernel interal si\_code magic

- From: Eric W. Biederman \<hidden\>
- Date: 2017-07-12 23:16:12 
- Message: https://ratatoskr.run/linux-api/2017/07/5041465.md

```text
Andrei Vagin [ref] writes:

>> diff --git a/arch/tile/kernel/traps.c b/arch/tile/kernel/traps.c
>> index 54804866f238..4433d1dc28e6 100644
>> --- a/arch/tile/kernel/traps.c
>> +++ b/arch/tile/kernel/traps.c
>> @@ -188,7 +188,6 @@ static int special_ill(tile_bundle_bits bundle, int *sigp, int *codep)
>>  
>>  	/* Make it the requested signal. */
>>  	*sigp = sig;
>> -	*codep = code | __SI_FAULT;
>
> Are you sure that we don't need to set codep here?

Looking closely we definitely do.  Good catch.  Thank you.

Eric
```