# Re: \[PATCH 2/4\] swait: add the missing killable swaits

- From: Greg KH \<gregkh@linuxfoundation.org\>
- Date: 2017-06-29 13:35:30 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2017/06/123417
- Thread: https://ratatoskr.run/linux-api/2017/06/122725/t.md

```text
On Thu, Jun 29, 2017 at 03:05:26PM +0200, Thomas Gleixner wrote:
> On Thu, 29 Jun 2017, Greg KH wrote:
> > On Wed, Jun 14, 2017 at 03:20:15PM -0700, Luis R. Rodriguez wrote:
> > Do you really still want to add these, now that we know we shouldn't be
> > using swait in "real" code? :)
> 
> And who defined that it should not be used in real code?

Linus did, in a different firmware thread.  You have to _really_ know
what you are doing to use this interface, and the firmware interface
shouldn't be using it.  So adding new apis just for firmware does not
seem like a wise decision at this point in time.

thanks,

greg k-h
```