# Re: \[RFC 2/3\] kcmp: Add KCMP\_EPOLL\_TFD mode to compare epoll target files

- From: Cyrill Gorcunov \<hidden\>
- Date: 2017-02-28 06:53:43 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2017/02/117517
- Thread: https://ratatoskr.run/linux-fsdevel/2017/02/117519/t.md

```text
On Mon, Feb 27, 2017 at 02:43:47PM -0800, Andrei Vagin wrote:
...
> > +
> > +		if (filp1 && filp_epoll) {
> > +			filp_tgt = get_epoll_tfile_raw_ptr(filp_epoll, slot.tfd, slot.toff);
> > +			if (IS_ERR(filp_tgt))
> > +				ret = PTR_ERR(filp_tgt);
> > +			else
> > +				ret = kcmp_ptr(filp1, filp_tgt, KCMP_EPOLL_TFD);
> 
> I think KCMP_FILE has to be used here ^^^^, because we compare files. We
> have to use the same function for all files to be able to sort them, don't we?

Yes. I already have v2 in my queue. Strictly speaking we can use separate
salt here but it will be waste of memory from userspace POV. I didn't send
v2 yet since I'm modifying criu still to test overall picture. Hopefully
will send today.
```