From: David Howells <dhowells@redhat.com> Date: 2016-11-18 10:29:46
Dave Chinner [off-list ref] wrote:
quoted
(13) FS_IOC_GETFLAGS value. These could be translated to BSD's st_flags.
Note that the Linux IOC flags are a mess and filesystems such as Ext4
define flags that aren't in linux/fs.h, so translation in the kernel
may be a necessity (or, possibly, we provide the filesystem type too).
And we now also have FS_IOC_FSGETXATTR that extends the flags
and information userspace can get from filesystems.
Btw, can you point me at the manpage that defines the fsxattr struct and its
flags?
Also, ioctl_list(2) should probably include FS_IOC_FS[GS]ETXATTR.
David
From: Dave Chinner <david@fromorbit.com> Date: 2016-11-18 21:27:29
On Fri, Nov 18, 2016 at 10:29:04AM +0000, David Howells wrote:
Dave Chinner [off-list ref] wrote:
quoted
quoted
(13) FS_IOC_GETFLAGS value. These could be translated to BSD's st_flags.
Note that the Linux IOC flags are a mess and filesystems such as Ext4
define flags that aren't in linux/fs.h, so translation in the kernel
may be a necessity (or, possibly, we provide the filesystem type too).
And we now also have FS_IOC_FSGETXATTR that extends the flags
and information userspace can get from filesystems.
Btw, can you point me at the manpage that defines the fsxattr struct and its
flags?
man xfsctl is the original source. However, ....
Also, ioctl_list(2) should probably include FS_IOC_FS[GS]ETXATTR.
... I thought patches had been sent to Michael to document them at
the VFS ioctl level. maybe I confused it with something else.....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
From: Dave Chinner <david@fromorbit.com> Date: 2016-11-18 22:17:31
On Fri, Nov 18, 2016 at 09:48:21PM +0000, David Howells wrote:
Dave Chinner [off-list ref] wrote:
quoted
quoted
Btw, can you point me at the manpage that defines the fsxattr struct and its
flags?
man xfsctl is the original source. However, ....
warthog>man xfsctl
No manual entry for xfsctl
This should be in the kernel manpages repo since it's kernel UAPI.
"original source" is where the API came from - that's
XFS_IOC_FSGETXATTR - and xfsctl from xfsprogs is where that was
documented. That page documents a bunch of other XFS specific
ioctls, too, so it is appropriately located.
Like I said, I thought patches had been sent to Michael to lift the
FS_IOC_FSGETXATTR documentation from this page into the official
linux man pages package. If not, that can be chased up separately,
but the XFS ioctl man page certainly does not belong there.
Cheers,
Dave.
--
Dave Chinner
david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org
From: Michael Kerrisk (man-pages) <hidden> Date: 2016-11-19 10:22:16
Hi Dave,
[Best to CC me when I'm mentioned in the discussion. I only caught
this by chance.]
On 18 November 2016 at 23:17, Dave Chinner [off-list ref] wrote:
On Fri, Nov 18, 2016 at 09:48:21PM +0000, David Howells wrote:
quoted
Dave Chinner [off-list ref] wrote:
quoted
quoted
Btw, can you point me at the manpage that defines the fsxattr struct and its
flags?
man xfsctl is the original source. However, ....
warthog>man xfsctl
No manual entry for xfsctl
This should be in the kernel manpages repo since it's kernel UAPI.
"original source" is where the API came from - that's
XFS_IOC_FSGETXATTR - and xfsctl from xfsprogs is where that was
documented. That page documents a bunch of other XFS specific
ioctls, too, so it is appropriately located.
Like I said, I thought patches had been sent to Michael to lift the
FS_IOC_FSGETXATTR documentation from this page into the official
linux man pages package. If not, that can be chased up separately,
but the XFS ioctl man page certainly does not belong there.
No patches for FS_IOC_FSGETXATTR documentation came to man-pages, as
far as I know. I'll be happy to take them.
Cheers,
Michael
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/