# Re: \[PATCH v6 0/5\] (mostly) Arch-independent livepatch

- From: Miroslav Benes \<hidden\>
- Date: 2016-03-23 13:50:15 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2016/03/4714588
- Thread: https://ratatoskr.run/linux-api/2016/03/4714275/t.md

```text
On Tue, 22 Mar 2016, Jessica Yu wrote:

> v6:
>  - Since we hard-code the field widths for the objname and symbol name
>    for the sscanf() calls, which are supposed to correspond to the values
>    of MODULE_NAME_LEN and KSYM_NAME_LEN, use BUILD_BUG_ON() to detect when
>    the values of these constants deviate from the expected values.
>  - Squash the sample livepatch module patch into patch 4
>    ("livepatch: reuse module loader code to write relocations") so 
>    git bisects don't break
>  - Don't need the klp_buf struct, just use plain char arrays to hold the
>    output of sscanf(). Also, no need to clear the bufs after every
>    invocation, as sscanf() takes care to put a null byte at the end of
>    the bufs.
>  - Fix compiler kbuild errors for the !CONFIG_LIVEPATCH case
>  - Fixed some small module.c nits

FWIW I am fine with all the changes and my Reviewed-by tag is still valid.

Great job, Jessica.

Miroslav
```