# Re: aio openat Re: \[PATCH 07/13\] aio: enabled thread based async fsync

- From: Linus Torvalds \<torvalds@linux-foundation.org\>
- Date: 2016-03-20 01:20:24 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2016/03/106296
- Thread: https://ratatoskr.run/linux-fsdevel/2016/01/103547/t.md

```text
On Mon, Mar 14, 2016 at 10:17 AM, Benjamin LaHaise [ref] wrote:
>
> I had some time last week to make an aio openat do what it can in
> submit context.  The results are an improvement: when openat is handled
> in submit context it completes in about half the time it takes compared
> to the round trip via the work queue, and it's not terribly much code
> either.

This looks good to me, and I do suspect that any of these aio paths
should strive to have a synchronous vs threaded model. I think that
makes the whole thing much more interesting from a performance
standpoint.

I still think the aio interface is really nasty,  but this together
with the table-based approach you posted earlier does make me a _lot_
happier about the implementation.It just looks way less hacky, and now
it ends up exposing a rather more clever implementation too.

             Linus

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
```
