# Re: \[PATCH v18 21/22\] ext4: Add richacl support

- From: Andreas Gruenbacher \<hidden\>
- Date: 2016-03-14 13:02:34 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2016/03/105666
- Thread: https://ratatoskr.run/linux-nfs/2016/02/104174/t.md

```text
On Fri, Mar 11, 2016 at 3:27 PM, Christoph Hellwig [ref] wrote:
>> +static inline int
>> +ext4_acl_chmod(struct inode *inode, umode_t mode)
>> +{
>> +     if (IS_RICHACL(inode))
>> +             return richacl_chmod(inode, inode->i_mode);
>> +     return posix_acl_chmod(inode, inode->i_mode);
>> +}
>
> Thi isn't ext4-specific and potentially duplicated in every caller.
> Please provide this as a common helper.

This can go in neither fs.h nor posix_acl.h nor richacl.h unless we
turn it into a macro, and I don't think we want to add a new header
file for such extreme trivia.

> Also while we're at it, the mode argument is ignore and the function
> always uses inode->i_mode instead.

Right, thanks.

Andreas
```