Re: [PATCH 6/7] blk-mq: enable polling support by default

2 messages, 2 authors, 2016-02-27 · open the first message on its own page

Re: [PATCH 6/7] blk-mq: enable polling support by default

From: Jeff Moyer <hidden>
Date: 2016-02-26 20:44:32

Hi, Christoph,

Christoph Hellwig [off-list ref] writes:
Now that applications need to explicitly ask for polling we can enable it
by default in blk-mq drivers.
I don't think this is a good idea.  I'd just enable it in nvme and the
micron driver for now.

Cheers,
Jeff
quoted hunk
Signed-off-by: Christoph Hellwig <redacted>
---
 include/linux/blkdev.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 4571ef1..458f6ef 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -499,7 +499,8 @@ struct request_queue {
 
 #define QUEUE_FLAG_MQ_DEFAULT	((1 << QUEUE_FLAG_IO_STAT) |		\
 				 (1 << QUEUE_FLAG_STACKABLE)	|	\
-				 (1 << QUEUE_FLAG_SAME_COMP))
+				 (1 << QUEUE_FLAG_SAME_COMP)	|	\
+				 (1 << QUEUE_FLAG_POLL))
 
 static inline void queue_lockdep_assert_held(struct request_queue *q)
 {

Re: [PATCH 6/7] blk-mq: enable polling support by default

From: Christoph Hellwig <hch@lst.de>
Date: 2016-02-27 08:56:51

On Fri, Feb 26, 2016 at 03:44:30PM -0500, Jeff Moyer wrote:
Hi, Christoph,

Christoph Hellwig [off-list ref] writes:
quoted
Now that applications need to explicitly ask for polling we can enable it
by default in blk-mq drivers.
I don't think this is a good idea.  I'd just enable it in nvme and the
micron driver for now.
I think my wording was a bit unclear - the flag to enable polling is
enabled everywhere.  You still need to implement the poll blk_mq operation,
which currently only NVMe implements.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help