# Re: \[PATCH 6/8\] mm: lru\_deactivate\_fn should clear PG\_referenced

- From: Michal Hocko \<hidden\>
- Date: 2015-10-30 12:47:16 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2015/10/4610607
- Thread: https://ratatoskr.run/linux-mm/2015/10/4610364/t.md

```text
On Fri 30-10-15 16:01:42, Minchan Kim wrote:
> deactivate_page aims for accelerate for reclaiming through
> moving pages from active list to inactive list so we should
> clear PG_referenced for the goal.

I might be missing something but aren't we using PG_referenced only for
pagecache (and shmem) pages?

> 
> Acked-by: Hugh Dickins <redacted>
> Suggested-by: Andrew Morton <redacted>
> Signed-off-by: Minchan Kim <redacted>
> ---
>  mm/swap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/swap.c b/mm/swap.c
> index d0eacc5f62a3..4a6aec976ab1 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -810,6 +810,7 @@ static void lru_deactivate_fn(struct page *page, struct lruvec *lruvec,
>  
>  		del_page_from_lru_list(page, lruvec, lru + LRU_ACTIVE);
>  		ClearPageActive(page);
> +		ClearPageReferenced(page);
>  		add_page_to_lru_list(page, lruvec, lru);
>  
>  		__count_vm_event(PGDEACTIVATE);
> -- 
> 1.9.1

-- 
Michal Hocko
SUSE Labs
```