# Re: \[PATCH v6 3/4\] of: overlay: add per overlay sysfs attributes

- From: Rob Herring \<hidden\>
- Date: 2015-10-20 21:55:00 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2015/10/4603216
- Thread: https://ratatoskr.run/linux-devicetree/2015/10/4602863/t.md

```text
On Tue, Oct 20, 2015 at 4:11 PM, Pantelis Antoniou
[ref] wrote:
> Hi Rob,
>
>> On Oct 21, 2015, at 00:04 , Rob Herring [ref] wrote:
>>
>> On Tue, Oct 20, 2015 at 2:13 PM, Pantelis Antoniou
>> [ref] wrote:
>>> * A per overlay can_remove sysfs attribute that reports whether
>>> the overlay can be removed or not due to another overlapping overlay.
>>>
>>> * A target sysfs attribute listing the target of each fragment,
>>> in a group named after the name of the fragment.

[...]

>>> @@ -255,6 +278,17 @@ err_fail:
>>>        return -EINVAL;
>>> }
>>>
>>> +static ssize_t target_show(struct kobject *kobj,
>>> +               struct fragment_attribute *fattr, char *buf)
>>> +{
>>> +       struct of_overlay_info *ovinfo = fattr->ovinfo;
>>> +
>>> +       return snprintf(buf, PAGE_SIZE, "%s\n",
>>> +                       of_node_full_name(ovinfo->target));
>>
>> This can be a link to the node itself, can't it?
>>
>
> Yes. Do you want it like this?

Yes, hence the suggestion. Unless you see some reason why not.

Rob
```