# Re: \[RFC v4 9/9\] kmsg: selftests

- From: Paul Osmialowski \<hidden\>
- Date: 2015-10-20 13:24:54 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2015/10/4602573
- Thread: https://ratatoskr.run/linux-api/2015/10/4601794/t.md

```text
Hi Shuah,

I'm attaching proposal version which makes use of inline functions from kselftest.h. I hope you'll like it.

Thanks,
Paul

On Tue, 20 Oct 2015, Paul Osmialowski wrote:

> Hi Shuah,
>
> Thanks for your comments,
>
> On Mon, 19 Oct 2015, Shuah Khan wrote:
>
>>> --- a/tools/testing/selftests/Makefile
>>> +++ b/tools/testing/selftests/Makefile
>>> @@ -7,6 +7,7 @@ TARGETS += ftrace
>>>  TARGETS += futex
>>>  TARGETS += kcmp
>>>  TARGETS += kdbus
>>
>> Doesn't look like this patch is based on linux-kselftest next
>> or Linus's latest. Please base your work on either one of the
>> above. Please make sure "make kselftest" from top level Makefile
>> doesn't break.
>>
>>> +TARGETS += kmsg
>
> Any guidelines what such test should be implemented (apart from use of kselftest.h API)?
>
>>> +kmsg-test: $(OBJS)
>>> +	$(CC) $(CFLAGS) $^ $(LDLIBS) -o $@
>>> +
>>> +run_tests:
>>> +	./kmsg-test --tap
>>
>> What does --tap do? Is this a longform option?
>> I don't see it in usage()
>>
>
> Should be removed - I copy-pasted parts of kdbus selftests Makefile not noticing that.
>
> Best regards,
> Paul
>
>
```

## Attachments

- [0009-kmsg-selftests.patch](https://ratatoskr.run/linux-api/2015/10/4602573/attachment/0) (text/x-diff, 27813 bytes)