# \[PATCH v4 10/79\] via\_drm.h: move struct via\_file\_private definition to drivers/gpu/drm/via/via\_drv.h

- Subsystems: DRM DRIVERS, DRM DRIVERS AND MISC GPU PATCHES, THE REST
- Maintainers: David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Linus Torvalds
- Status: SUPERSEDED (Superseded by v06 posted 2017-08-06)
- Superseded by v06 (posted 2017-08-06).
- Revision v4 (4 revisions archived).
- List: linux-api
- 4 messages, 3 authors
- Page: https://ratatoskr.run/linux-api/2015/10/4598262/t

## \[PATCH v4 10/79\] via\_drm.h: move struct via\_file\_private definition to drivers/gpu/drm/via/via\_drv.h

- From: Mikko Rapeli \<hidden\>
- Date: 2015-10-15 06:12:10 
- Message: https://ratatoskr.run/linux-api/2015/10/4598262.md

```text
Fixes userspace compile error since list_head is not exported to userspace
headers.

Suggested by Emil Velikov [ref] at
https://lkml.org/lkml/2015/6/3/792

Signed-off-by: Mikko Rapeli <redacted>
---
 drivers/gpu/drm/via/via_drv.h | 4 ++++
 include/uapi/drm/via_drm.h    | 4 ----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/via/via_drv.h b/drivers/gpu/drm/via/via_drv.h
index ef8c500..875e65a 100644
--- a/drivers/gpu/drm/via/via_drv.h
+++ b/drivers/gpu/drm/via/via_drv.h
@@ -102,6 +102,10 @@ typedef struct drm_via_private {
 	uint32_t dma_diff;
 } drm_via_private_t;
 
+struct via_file_private {
+	struct list_head obj_list;
+};
+
 enum via_family {
   VIA_OTHER = 0,     /* Baseline */
   VIA_PRO_GROUP_A,   /* Another video engine and DMA commands */
diff --git a/include/uapi/drm/via_drm.h b/include/uapi/drm/via_drm.h
index d19c0e2..c8c053a 100644
--- a/include/uapi/drm/via_drm.h
+++ b/include/uapi/drm/via_drm.h
@@ -271,8 +271,4 @@ typedef struct drm_via_dmablit {
 	drm_via_blitsync_t sync;
 } drm_via_dmablit_t;
 
-struct via_file_private {
-	struct list_head obj_list;
-};
-
 #endif				/* _VIA_DRM_H_ */
-- 
2.5.0
```

## Re: \[PATCH v4 10/79\] via\_drm.h: move struct via\_file\_private definition to drivers/gpu/drm/via/via\_drv.h

- From: Emil Velikov \<hidden\>
- Date: 2015-10-21 14:36:29 
- Message: https://ratatoskr.run/linux-api/2015/10/4603799.md

```text
On 15 October 2015 at 06:55, Mikko Rapeli [ref] wrote:
> Fixes userspace compile error since list_head is not exported to userspace
> headers.
>
> Suggested by Emil Velikov [ref] at
> https://lkml.org/lkml/2015/6/3/792
>
> Signed-off-by: Mikko Rapeli <redacted>
We're safe as the only users of the struct already include via_drv.h.

Reviewed-by: Emil Velikov <redacted>

Daniel can you pick this up (esp. since you added it with commit
c828e20456301b0f5192a1f75e8bf8a6afd15551)

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
```

## Re: \[PATCH v4 10/79\] via\_drm.h: move struct via\_file\_private definition to drivers/gpu/drm/via/via\_drv.h

- From: Daniel Vetter \<hidden\>
- Date: 2015-10-21 15:33:29 
- Message: https://ratatoskr.run/linux-api/2015/10/4603876.md

```text
On Wed, Oct 21, 2015 at 03:36:22PM +0100, Emil Velikov wrote:
> On 15 October 2015 at 06:55, Mikko Rapeli [ref] wrote:
> > Fixes userspace compile error since list_head is not exported to userspace
> > headers.
> >
> > Suggested by Emil Velikov [ref] at
> > https://lkml.org/lkml/2015/6/3/792
> >
> > Signed-off-by: Mikko Rapeli <redacted>
> We're safe as the only users of the struct already include via_drv.h.
> 
> Reviewed-by: Emil Velikov <redacted>
> 
> Daniel can you pick this up (esp. since you added it with commit
> c828e20456301b0f5192a1f75e8bf8a6afd15551)

Dave already applied it.
-Daniel

> 
> Thanks
> Emil

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
```

## Re: \[PATCH v4 10/79\] via\_drm.h: move struct via\_file\_private definition to drivers/gpu/drm/via/via\_drv.h

- From: Emil Velikov \<hidden\>
- Date: 2015-10-21 16:25:48 
- Message: https://ratatoskr.run/linux-api/2015/10/4603967.md

```text
On 21 October 2015 at 16:33, Daniel Vetter [ref] wrote:
> On Wed, Oct 21, 2015 at 03:36:22PM +0100, Emil Velikov wrote:
>> On 15 October 2015 at 06:55, Mikko Rapeli [ref] wrote:
>> > Fixes userspace compile error since list_head is not exported to userspace
>> > headers.
>> >
>> > Suggested by Emil Velikov [ref] at
>> > https://lkml.org/lkml/2015/6/3/792
>> >
>> > Signed-off-by: Mikko Rapeli <redacted>
>> We're safe as the only users of the struct already include via_drv.h.
>>
>> Reviewed-by: Emil Velikov <redacted>
>>
>> Daniel can you pick this up (esp. since you added it with commit
>> c828e20456301b0f5192a1f75e8bf8a6afd15551)
>
> Dave already applied it.
Did not notice. Sorry for the noise.

-Emil
```