Re: [PATCH v5 8/9] vfs: Add vfs_copy_file_range() support for pagecache copies

3 messages, 3 authors, 2015-10-16 · open the first message on its own page

Re: [PATCH v5 8/9] vfs: Add vfs_copy_file_range() support for pagecache copies

From: Christoph Hellwig <hidden>
Date: 2015-10-16 05:38:08

On Thu, Oct 15, 2015 at 08:24:51AM -0400, Austin S Hemmelgarn wrote:
My only point with saying we shouldn't reflink by default is that there are
many (unintelligent) people who will assume that since the syscall has copy
in it's name, that's what it will do; and, while I don't think we should
cater to such individuals, it does make sense to have a syscall that says in
it's name that it copies data actually do so by default.
As far as the user is concerned a reflink is a copy.  A very efficient
copy.

Re: [PATCH v5 8/9] vfs: Add vfs_copy_file_range() support for pagecache copies

From: Austin S Hemmelgarn <hidden>
Date: 2015-10-16 11:46:41

On 2015-10-16 01:38, Christoph Hellwig wrote:
On Thu, Oct 15, 2015 at 08:24:51AM -0400, Austin S Hemmelgarn wrote:
quoted
My only point with saying we shouldn't reflink by default is that there are
many (unintelligent) people who will assume that since the syscall has copy
in it's name, that's what it will do; and, while I don't think we should
cater to such individuals, it does make sense to have a syscall that says in
it's name that it copies data actually do so by default.
As far as the user is concerned a reflink is a copy.  A very efficient
copy.
I should have been specific, what I meant was that some people will 
assume that it actually creates a physical, on-disk byte-for-byte copy 
of the data.  There are many people out there (and sadly I have to deal 
with some at work) who are absolutely terrified of the concept of data 
deduplication, and will likely refuse to use this syscall for _anything_ 
if it reflinks by default on filesystems that support it.

Re: [PATCH v5 8/9] vfs: Add vfs_copy_file_range() support for pagecache copies

From: Pádraig Brady <hidden>
Date: 2015-10-16 12:02:27

On 16/10/15 12:46, Austin S Hemmelgarn wrote:
On 2015-10-16 01:38, Christoph Hellwig wrote:
quoted
On Thu, Oct 15, 2015 at 08:24:51AM -0400, Austin S Hemmelgarn wrote:
quoted
My only point with saying we shouldn't reflink by default is that there are
many (unintelligent) people who will assume that since the syscall has copy
in it's name, that's what it will do; and, while I don't think we should
cater to such individuals, it does make sense to have a syscall that says in
it's name that it copies data actually do so by default.
As far as the user is concerned a reflink is a copy.  A very efficient
copy.
I should have been specific, what I meant was that some people will 
assume that it actually creates a physical, on-disk byte-for-byte copy 
of the data.  There are many people out there (and sadly I have to deal 
with some at work) who are absolutely terrified of the concept of data 
deduplication, and will likely refuse to use this syscall for _anything_ 
if it reflinks by default on filesystems that support it.
Right. reflinking is transparent to the user, though its consequences are not.
Consequences being the possible extra latency or ENOSPC on CoW.
Therefore reflinking should be an explicit action/flag IMHO.

cheers,
Pádraig.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help