Re: [PATCH 11/13] Always define MAX_RAW_MINORS as 65535 in userspace

On 09/14/2015 03:50 PM, Palmer Dabbelt wrote:

While I don't think this was ever meant to be exposed to userspace, if
anyone is using it then this will at least provide a correct (if
unlikely) definition.

MAX_RAW_MINORS used to be used in the kernel, where it's been replaced
with CONFIG_MAX_RAW_MINORS.

Note that there's a checkpatch.pl warning about a split config string
here, but I've left that alone.

From a UAPI perspective I would think the right value would be 2^20.

	-hpa

On Tue, 15 Sep 2015 13:42:47 PDT (-0700), hpa@zytor.com wrote:

On 09/14/2015 03:50 PM, Palmer Dabbelt wrote:

quoted

While I don't think this was ever meant to be exposed to userspace, if
anyone is using it then this will at least provide a correct (if
unlikely) definition.

MAX_RAW_MINORS used to be used in the kernel, where it's been replaced
with CONFIG_MAX_RAW_MINORS.

Note that there's a checkpatch.pl warning about a split config string
here, but I've left that alone.

From a UAPI perspective I would think the right value would be 2^20.

Wow, I'm super surprised.  For some reason I thought major/minor
numbers were 16 bits, but according to glibc I just have no idea what
I'm doing :).

Thanks for catching this!