# Re: \[linux-4.2-rc3/tools/testing/selftests/futex/functional/futex\_requeue\_pi\_signal\_restart.c:194: bad if condition ?

- From: Darren Hart \<hidden\>
- Date: 2015-07-20 21:03:57 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2015/07/13329257
- Thread: https://ratatoskr.run/linux-api/2015/07/13329257/t.md

```text
On Mon, Jul 20, 2015 at 08:42:16AM -0600, Shuah Khan wrote:
> On 07/20/2015 03:26 AM, David Binderman wrote:
> > Hello there,
> > 
> > [linux-4.2-rc3/tools/testing/selftests/futex/functional/futex_requeue_pi_signal_restart.c:194]: (style) Expression is always false because 'else if' condition matches previous condition at line 191.
> > 
> > Source code is
> > 
> >         if (res> 0) {
> >             atomic_set(&requeued, 1);
> >             break;
> >         } else if (res> 0) {
> > 
> 
> Hi Daren,
> 
> Is this something that could be fixed?

Ew, yuck. I'll look into this and provide a fix.

Thanks for the report David.

-- 
Darren Hart
Intel Open Source Technology Center
```