# Re: \[PATCH 45/45\] include/uapi/asm-generic/ucontext.h: include signal.h and sigcontext.h

- From: Mikko Rapeli \<hidden\>
- Date: 2015-03-11 01:59:37 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2015/03/4448054
- Thread: https://ratatoskr.run/linux-arch/2015/02/4432073/t.md

```text
On Tue, Feb 17, 2015 at 10:10:42AM +0100, Arnd Bergmann wrote:
> On Tuesday 17 February 2015 00:05:48 Mikko Rapeli wrote:
> >  #ifndef __ASM_GENERIC_UCONTEXT_H
> >  #define __ASM_GENERIC_UCONTEXT_H
> >  
> > +#include <asm-generic/signal.h>
> > +#include <asm/sigcontext.h>
> > +
> >  struct ucontext {
> > 
> 
> Including another asm-generic header here is a bad idea: it breaks
> if an architecture overrides asm/signal.h with its own version
> but wants to use the asm-generic/ucontext.h file.
> 
> It would be best to just use linux/signal.h here, which includes
> the correct architecture specific files.

Thanks, I will use asm/signal.h instead.

-Mikko
```