# Re: \[PATCH v2 14/18\] ARM: Add STM32 family machine - List: linux-api - 4 messages, 3 authors - Page: https://ratatoskr.run/linux-api/2015/02/4434839/t ## Re: \[PATCH v2 14/18\] ARM: Add STM32 family machine - From: Uwe Kleine-König \ - Date: 2015-02-20 20:01:12 - Message: https://ratatoskr.run/linux-api/2015/02/4434839.md ```text Hello, On Fri, Feb 20, 2015 at 07:01:13PM +0100, Maxime Coquelin wrote: > STMicrolectronics's STM32 series is a family of Cortex-M > microcontrollers. It is used in various applications, and > proposes a wide range of peripherals. > > Signed-off-by: Maxime Coquelin > --- > Documentation/arm/stm32/overview.txt | 32 ++++++++++++++++++++++++++ > Documentation/arm/stm32/stm32f429-overview.txt | 22 ++++++++++++++++++ > arch/arm/Kconfig | 22 ++++++++++++++++++ > arch/arm/Makefile | 1 + > arch/arm/mach-stm32/Makefile | 1 + > arch/arm/mach-stm32/Makefile.boot | 0 > arch/arm/mach-stm32/board-dt.c | 31 +++++++++++++++++++++++++ > 7 files changed, 109 insertions(+) > create mode 100644 Documentation/arm/stm32/overview.txt > create mode 100644 Documentation/arm/stm32/stm32f429-overview.txt > create mode 100644 arch/arm/mach-stm32/Makefile > create mode 100644 arch/arm/mach-stm32/Makefile.boot > create mode 100644 arch/arm/mach-stm32/board-dt.c > > diff --git a/Documentation/arm/stm32/overview.txt b/Documentation/arm/stm32/overview.txt > new file mode 100644 > index 0000000..d8bf6bb > --- /dev/null > +++ b/Documentation/arm/stm32/overview.txt > @@ -0,0 +1,32 @@ > + STM32 ARM Linux Overview > + ========================== > + > +Introduction > +------------ > + > + The STMicroelectronics family of Cortex-M based MCUs are supported by the > + 'STM32' platform of ARM Linux. Currently only the STM32F429 is supported. > + > + > +Configuration > +------------- > + > + A generic configuration is provided for STM32 family, and can be used as the > + default by > + make stm32_defconfig > + > +Layout > +------ > + > + All the files for multiple machine families are located in the platform code > + contained in arch/arm/mach-stm32 > + > + There is a generic board board-dt.c in the mach folder which support > + Flattened Device Tree, which means, It works with any compatible board with > + Device Trees. > + > + > +Document Author > +--------------- > + > + Maxime Coquelin [ref] > diff --git a/Documentation/arm/stm32/stm32f429-overview.txt b/Documentation/arm/stm32/stm32f429-overview.txt > new file mode 100644 > index 0000000..5206822 > --- /dev/null > +++ b/Documentation/arm/stm32/stm32f429-overview.txt > @@ -0,0 +1,22 @@ > + STM32F429 Overview > + ================== > + > + Introduction > + ------------ > + The STM32F429 is a Cortex-M4 MCU aimed at various applications. > + It features: > + - ARM Cortex-M4 up to 180MHz with FPU > + - 2MB internal Flash Memory > + - External memory support through FMC controller (PSRAM, SDRAM, NOR, NAND) > + - I2C, SPI, SAI, CAN, USB OTG, Ethernet controllers > + - LCD controller & Camera interface > + - Cryptographic processor > + > + Resources > + --------- > + Datasheet and reference manual are publicly available on ST website: > + - http://www.st.com/web/en/catalog/mmc/FM141/SC1169/SS1577/LN1806?ecmp=stm32f429-439_pron_pr-ces2014_nov2013 > + > + Document Author > + --------------- > + Maxime Coquelin [ref] > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > index 97d07ed..cfd9532 100644 > --- a/arch/arm/Kconfig > +++ b/arch/arm/Kconfig > @@ -774,6 +774,28 @@ config ARCH_OMAP1 > help > Support for older TI OMAP1 (omap7xx, omap15xx or omap16xx) > > +config ARCH_STM32 > + bool "STMicrolectronics STM32" > + depends on !MMU > + select ARCH_REQUIRE_GPIOLIB > + select ARM_NVIC > + select AUTO_ZRELADDR > + select ARCH_HAS_RESET_CONTROLLER > + select RESET_CONTROLLER > + select PINCTRL > + select PINCTRL_STM32 > + select CLKSRC_OF > + select ARMV7M_SYSTICK > + select COMMON_CLK > + select CPU_V7M > + select GENERIC_CLOCKEVENTS > + select NO_DMA > + select NO_IOPORT_MAP > + select SPARSE_IRQ > + select USE_OF Please sort this list alphabetically. > + help > + Support for STMicorelectronics STM32 processors. > + > endchoice > > menu "Multiple platform selection" > diff --git a/arch/arm/Makefile b/arch/arm/Makefile > index c1785ee..7d00659 100644 > --- a/arch/arm/Makefile > +++ b/arch/arm/Makefile > @@ -196,6 +196,7 @@ machine-$(CONFIG_ARCH_SHMOBILE) += shmobile > machine-$(CONFIG_ARCH_SIRF) += prima2 > machine-$(CONFIG_ARCH_SOCFPGA) += socfpga > machine-$(CONFIG_ARCH_STI) += sti > +machine-$(CONFIG_ARCH_STM32) += stm32 > machine-$(CONFIG_ARCH_SUNXI) += sunxi > machine-$(CONFIG_ARCH_TEGRA) += tegra > machine-$(CONFIG_ARCH_U300) += u300 > diff --git a/arch/arm/mach-stm32/Makefile b/arch/arm/mach-stm32/Makefile > new file mode 100644 > index 0000000..bd0b7b5 > --- /dev/null > +++ b/arch/arm/mach-stm32/Makefile > @@ -0,0 +1 @@ > +obj-y += board-dt.o > diff --git a/arch/arm/mach-stm32/Makefile.boot b/arch/arm/mach-stm32/Makefile.boot > new file mode 100644 > index 0000000..e69de29 Maybe note there why this file exists and can be empty. Feel free to copy the content of efm32's Makefile.boot. > diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm32/board-dt.c > new file mode 100644 > index 0000000..1d681b3 > --- /dev/null > +++ b/arch/arm/mach-stm32/board-dt.c > @@ -0,0 +1,31 @@ > +/* > + * Copyright (C) Maxime Coquelin 2015 > + * Author: Maxime Coquelin [ref] > + * License terms: GNU General Public License (GPL), version 2 > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +static const char *const stm32_compat[] __initconst = { > + "st,stm32f429", > + NULL > +}; > + > +static void __init stm32_timer_init(void) > +{ > + of_clk_init(NULL); > + reset_controller_of_init(); > + clocksource_of_init(); Hmm, if reset_controller_of_init was called automatically you wouldn't need that, right? Maybe arange for that instead? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | ``` ## Re: \[PATCH v2 14/18\] ARM: Add STM32 family machine - From: Paul Bolle \ - Date: 2015-02-20 21:37:29 - Message: https://ratatoskr.run/linux-api/2015/02/4434877.md ```text On Fri, 2015-02-20 at 21:00 +0100, Uwe Kleine-König wrote: > On Fri, Feb 20, 2015 at 07:01:13PM +0100, Maxime Coquelin wrote: > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index 97d07ed..cfd9532 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -774,6 +774,28 @@ config ARCH_OMAP1 > > help > > Support for older TI OMAP1 (omap7xx, omap15xx or omap16xx) > > > > +config ARCH_STM32 > > + bool "STMicrolectronics STM32" > > + depends on !MMU > > + select ARCH_REQUIRE_GPIOLIB > > + select ARM_NVIC > > + select AUTO_ZRELADDR > > + select ARCH_HAS_RESET_CONTROLLER > > + select RESET_CONTROLLER > > + select PINCTRL > > + select PINCTRL_STM32 > > + select CLKSRC_OF > > + select ARMV7M_SYSTICK > > + select COMMON_CLK > > + select CPU_V7M > > + select GENERIC_CLOCKEVENTS > > + select NO_DMA > > + select NO_IOPORT_MAP > > + select SPARSE_IRQ > > + select USE_OF > Please sort this list alphabetically. And drop select NO_DMA You copied that from ARCH_EFM32, but it's pointless on arm (as arch/arm/ doesn't provide a NO_DMA Kconfig symbol). I submitted a patch last year to drop it from ARCH_EFM32, which Uwe Acked, but then nothing happened. I'm to blame, as I should have sent a reminder. > > + help > > + Support for STMicorelectronics STM32 processors. > > + > > endchoice > > > > menu "Multiple platform selection" Paul Bolle ``` ## Re: \[PATCH v2 14/18\] ARM: Add STM32 family machine - From: Maxime Coquelin \ - Date: 2015-02-25 12:04:01 - Message: https://ratatoskr.run/linux-api/2015/02/4437299.md ```text 2015-02-20 21:00 GMT+01:00 Uwe Kleine-König [ref]: > Hello, > > On Fri, Feb 20, 2015 at 07:01:13PM +0100, Maxime Coquelin wrote: >> STMicrolectronics's STM32 series is a family of Cortex-M >> microcontrollers. It is used in various applications, and >> proposes a wide range of peripherals. >> >> Signed-off-by: Maxime Coquelin >> --- >> Documentation/arm/stm32/overview.txt | 32 ++++++++++++++++++++++++++ >> Documentation/arm/stm32/stm32f429-overview.txt | 22 ++++++++++++++++++ >> arch/arm/Kconfig | 22 ++++++++++++++++++ >> arch/arm/Makefile | 1 + >> arch/arm/mach-stm32/Makefile | 1 + >> arch/arm/mach-stm32/Makefile.boot | 0 >> arch/arm/mach-stm32/board-dt.c | 31 +++++++++++++++++++++++++ >> 7 files changed, 109 insertions(+) >> create mode 100644 Documentation/arm/stm32/overview.txt >> create mode 100644 Documentation/arm/stm32/stm32f429-overview.txt >> create mode 100644 arch/arm/mach-stm32/Makefile >> create mode 100644 arch/arm/mach-stm32/Makefile.boot >> create mode 100644 arch/arm/mach-stm32/board-dt.c >> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index 97d07ed..cfd9532 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -774,6 +774,28 @@ config ARCH_OMAP1 >> help >> Support for older TI OMAP1 (omap7xx, omap15xx or omap16xx) >> >> +config ARCH_STM32 >> + bool "STMicrolectronics STM32" >> + depends on !MMU >> + select ARCH_REQUIRE_GPIOLIB >> + select ARM_NVIC >> + select AUTO_ZRELADDR >> + select ARCH_HAS_RESET_CONTROLLER >> + select RESET_CONTROLLER >> + select PINCTRL >> + select PINCTRL_STM32 >> + select CLKSRC_OF >> + select ARMV7M_SYSTICK >> + select COMMON_CLK >> + select CPU_V7M >> + select GENERIC_CLOCKEVENTS >> + select NO_DMA >> + select NO_IOPORT_MAP >> + select SPARSE_IRQ >> + select USE_OF > Please sort this list alphabetically. Ok, I will do for v3. > >> + help >> + Support for STMicorelectronics STM32 processors. >> + >> endchoice >> >> menu "Multiple platform selection" >> diff --git a/arch/arm/Makefile b/arch/arm/Makefile >> index c1785ee..7d00659 100644 >> --- a/arch/arm/Makefile >> +++ b/arch/arm/Makefile >> @@ -196,6 +196,7 @@ machine-$(CONFIG_ARCH_SHMOBILE) += shmobile >> machine-$(CONFIG_ARCH_SIRF) += prima2 >> machine-$(CONFIG_ARCH_SOCFPGA) += socfpga >> machine-$(CONFIG_ARCH_STI) += sti >> +machine-$(CONFIG_ARCH_STM32) += stm32 >> machine-$(CONFIG_ARCH_SUNXI) += sunxi >> machine-$(CONFIG_ARCH_TEGRA) += tegra >> machine-$(CONFIG_ARCH_U300) += u300 >> diff --git a/arch/arm/mach-stm32/Makefile b/arch/arm/mach-stm32/Makefile >> new file mode 100644 >> index 0000000..bd0b7b5 >> --- /dev/null >> +++ b/arch/arm/mach-stm32/Makefile >> @@ -0,0 +1 @@ >> +obj-y += board-dt.o >> diff --git a/arch/arm/mach-stm32/Makefile.boot b/arch/arm/mach-stm32/Makefile.boot >> new file mode 100644 >> index 0000000..e69de29 > Maybe note there why this file exists and can be empty. Feel free to > copy the content of efm32's Makefile.boot. Ok, I will copy efm32's Makefile.boot content. Do you know why your patch has not been applied yet? > >> diff --git a/arch/arm/mach-stm32/board-dt.c b/arch/arm/mach-stm32/board-dt.c >> new file mode 100644 >> index 0000000..1d681b3 >> --- /dev/null >> +++ b/arch/arm/mach-stm32/board-dt.c >> @@ -0,0 +1,31 @@ >> +/* >> + * Copyright (C) Maxime Coquelin 2015 >> + * Author: Maxime Coquelin [ref] >> + * License terms: GNU General Public License (GPL), version 2 >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> + >> +static const char *const stm32_compat[] __initconst = { >> + "st,stm32f429", >> + NULL >> +}; >> + >> +static void __init stm32_timer_init(void) >> +{ >> + of_clk_init(NULL); >> + reset_controller_of_init(); >> + clocksource_of_init(); > Hmm, if reset_controller_of_init was called automatically you wouldn't > need that, right? Maybe arange for that instead? This is what I did in the v1: http://marc.info/?l=linux-arm-kernel&m=142376341008550&w=2 But Rob advised to put it elsewhere. Thanks, Maxime > > Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ``` ## Re: \[PATCH v2 14/18\] ARM: Add STM32 family machine - From: Maxime Coquelin \ - Date: 2015-02-25 12:04:54 - Message: https://ratatoskr.run/linux-api/2015/02/4437300.md ```text 2015-02-20 22:37 GMT+01:00 Paul Bolle [ref]: > On Fri, 2015-02-20 at 21:00 +0100, Uwe Kleine-König wrote: >> On Fri, Feb 20, 2015 at 07:01:13PM +0100, Maxime Coquelin wrote: >> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> > index 97d07ed..cfd9532 100644 >> > --- a/arch/arm/Kconfig >> > +++ b/arch/arm/Kconfig >> > @@ -774,6 +774,28 @@ config ARCH_OMAP1 >> > help >> > Support for older TI OMAP1 (omap7xx, omap15xx or omap16xx) >> > >> > +config ARCH_STM32 >> > + bool "STMicrolectronics STM32" >> > + depends on !MMU >> > + select ARCH_REQUIRE_GPIOLIB >> > + select ARM_NVIC >> > + select AUTO_ZRELADDR >> > + select ARCH_HAS_RESET_CONTROLLER >> > + select RESET_CONTROLLER >> > + select PINCTRL >> > + select PINCTRL_STM32 >> > + select CLKSRC_OF >> > + select ARMV7M_SYSTICK >> > + select COMMON_CLK >> > + select CPU_V7M >> > + select GENERIC_CLOCKEVENTS >> > + select NO_DMA >> > + select NO_IOPORT_MAP >> > + select SPARSE_IRQ >> > + select USE_OF >> Please sort this list alphabetically. > > And drop > select NO_DMA > > You copied that from ARCH_EFM32, but it's pointless on arm (as arch/arm/ > doesn't provide a NO_DMA Kconfig symbol). You are right, I will drop NO_DMA in v3. Thanks, Maxime > > I submitted a patch last year to drop it from ARCH_EFM32, which Uwe > Acked, but then nothing happened. I'm to blame, as I should have sent a > reminder. > >> > + help >> > + Support for STMicorelectronics STM32 processors. >> > + >> > endchoice >> > >> > menu "Multiple platform selection" > > > Paul Bolle > ```