# \[PATCH 43/45\] include/uapi/linux/netfilter\_bridge.h: include if.h

- Subsystems: NETFILTER, THE REST
- Maintainers: Pablo Neira Ayuso, Florian Westphal, Linus Torvalds
- List: linux-api
- 3 messages, 2 authors
- Page: https://ratatoskr.run/linux-api/2015/02/4432071/t

## \[PATCH 43/45\] include/uapi/linux/netfilter\_bridge.h: include if.h

- From: Mikko Rapeli \<hidden\>
- Date: 2015-02-16 23:08:16 
- Message: https://ratatoskr.run/linux-api/2015/02/4432071.md

```text
Fixes userspace compilation errors like:

error: field ‘in’ has incomplete type
struct in_addr in;

Signed-off-by: Mikko Rapeli <redacted>
---
 include/uapi/linux/netfilter_bridge.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uapi/linux/netfilter_bridge.h b/include/uapi/linux/netfilter_bridge.h
index a5eda6d..5bb0528 100644
--- a/include/uapi/linux/netfilter_bridge.h
+++ b/include/uapi/linux/netfilter_bridge.h
@@ -4,6 +4,7 @@
 /* bridge-specific defines for netfilter. 
  */
 
+#include <linux/if.h>
 #include <linux/netfilter.h>
 #include <linux/if_ether.h>
 #include <linux/if_vlan.h>
-- 
2.1.4
```

## Re: \[PATCH 43/45\] include/uapi/linux/netfilter\_bridge.h: include if.h

- From: Jan Engelhardt \<hidden\>
- Date: 2015-02-17 00:02:54 
- Message: https://ratatoskr.run/linux-api/2015/02/4432080.md

```text
On Tuesday 2015-02-17 00:05, Mikko Rapeli wrote:

>Fixes userspace compilation errors like:
>
>error: field ‘in’ has incomplete type
>struct in_addr in;
> 
>+#include <linux/if.h>

Patch 36/45 included linux/in.h instead of linux/if.h for addressing "in has incomplete
type". Should this be used here too?
```

## Re: \[PATCH 43/45\] include/uapi/linux/netfilter\_bridge.h: include if.h

- From: Mikko Rapeli \<hidden\>
- Date: 2015-03-11 01:49:57 
- Message: https://ratatoskr.run/linux-api/2015/03/4448052.md

```text
On Tue, Feb 17, 2015 at 01:02:50AM +0100, Jan Engelhardt wrote:
> On Tuesday 2015-02-17 00:05, Mikko Rapeli wrote:
> 
> >Fixes userspace compilation errors like:
> >
> >error: field ‘in’ has incomplete type
> >struct in_addr in;
> > 
> >+#include <linux/if.h>
> 
> Patch 36/45 included linux/in.h instead of linux/if.h for addressing "in has incomplete
> type". Should this be used here too?

It could, yes. It seems I cut some corners since this was hiding behind it:

In file included from ./linux/netfilter_bridge.h:11:0,
                 from ./linux/netfilter_bridge.c:1:
./linux/if_pppox.h:42:11: error: ‘IFNAMSIZ’ undeclared here (not in a function)
  char          dev[IFNAMSIZ];          /* Local device to use */

I'll fix these.

-Mikko
```