DORMANTno replies

[PATCH] Documentation: dell-laptop: correct als_setting description

From: Gabriele Mazzotta <hidden>
Date: 2015-01-02 11:07:48
Also in: lkml
Subsystem: the rest · Maintainer: Linus Torvalds

It was incorrectly stated that als_setting is to enable and disable
the ambient light sensor on supported system rather than setting a
threshold value. Correct the description and add a note to make more
clear what could be the effect of changing als_setting.

Reported-by: Brian Norris <redacted>
Signed-off-by: Gabriele Mazzotta <redacted>
---
 Documentation/ABI/testing/sysfs-platform-dell-laptop | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-platform-dell-laptop b/Documentation/ABI/testing/sysfs-platform-dell-laptop
index 7969443..a40c217 100644
--- a/Documentation/ABI/testing/sysfs-platform-dell-laptop
+++ b/Documentation/ABI/testing/sysfs-platform-dell-laptop
@@ -4,10 +4,12 @@ KernelVersion:	3.19
 Contact:	Gabriele Mazzotta <gabriele.mzt-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
 		Pali Rohár <pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
 Description:
-		This file allows to control the automatic keyboard
-		illumination mode on some systems that have an ambient
-		light sensor. Write 1 to this file to enable the auto
-		mode, 0 to disable it.
+		This file allows to set at which value reported by the
+		ambient light sensor the keyboard backlight has to be
+		turned on or off.
+
+		Note that the 'als' trigger must be supported and enabled
+		for this setting to have any effect.
 
 What:		/sys/class/leds/dell::kbd_backlight/start_triggers
 Date:		December 2014
@@ -32,6 +34,13 @@ Description:
 
 		Note that not all the available triggers can be configured.
 
+		Note also that enabling the 'als' trigger could simply
+		alter the behavior of the other triggers and not allow
+		the ambient light sensor control the keyboard illumination
+		independently. It could prevent other triggers from turning
+		the keyboard backlight on or force them to turn it off
+		depending on the current ambient light and als_setting.
+
 What:		/sys/class/leds/dell::kbd_backlight/stop_timeout
 Date:		December 2014
 KernelVersion:	3.19
-- 
2.1.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help