Re: [PATCH v6 4/7] fs/fuse: support compiling out splice

2 messages, 2 authors, 2014-12-07 · open the first message on its own page

Re: [PATCH v6 4/7] fs/fuse: support compiling out splice

From: Miklos Szeredi <hidden>
Date: 2014-12-05 10:44:36

On Thu, Dec 4, 2014 at 6:50 PM, Pieter Smith [off-list ref] wrote:
To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This
struct is exported by fs/splice. The goal of the larger patch set is to
completely compile out fs/splice, so uses of the exported struct need to be
compiled out along with fs/splice.

This patch therefore compiles out splice support in fs/fuse when
CONFIG_SYSCALL_SPLICE is undefined.

Signed-off-by: Pieter Smith <redacted>

In the future could you PLEASE PLEASE cut the fuse-devel Cc from the
non-fuse specific patches (and I guess that goes for any other
subsystem specific lists and persons as well)?

Otherwise:

Acked-by: Miklos Szeredi <redacted>

Thanks,
Miklos

Re: [PATCH v6 4/7] fs/fuse: support compiling out splice

From: Pieter Smith <hidden>
Date: 2014-12-07 13:00:40

On Fri, Dec 05, 2014 at 11:44:36AM +0100, Miklos Szeredi wrote:
On Thu, Dec 4, 2014 at 6:50 PM, Pieter Smith [off-list ref] wrote:
quoted
To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This
struct is exported by fs/splice. The goal of the larger patch set is to
completely compile out fs/splice, so uses of the exported struct need to be
compiled out along with fs/splice.

This patch therefore compiles out splice support in fs/fuse when
CONFIG_SYSCALL_SPLICE is undefined.

Signed-off-by: Pieter Smith <redacted>

In the future could you PLEASE PLEASE cut the fuse-devel Cc from the
non-fuse specific patches (and I guess that goes for any other
subsystem specific lists and persons as well)?

Otherwise:

Acked-by: Miklos Szeredi <redacted>

Thanks,
Miklos
I added your Acked-by and removed you and fuse-dev from postings on future
versions of this patch-set.

Thanks,
Pieter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help