# Re: \[PATCH 4/4\] vfs: RWF\_NONBLOCK flag for preadv2

- From: Milosz Tanski \<hidden\>
- Date: 2014-10-24 17:16:04 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2014/10/89286
- Thread: https://ratatoskr.run/linux-fsdevel/2014/10/89283/t.md

```text
On Fri, Oct 24, 2014 at 11:55 AM, Jeff Moyer [ref] wrote:
> Milosz Tanski [ref] writes:
>
>> Filesystems that generic_file_read_iter will not be allowed to perform
>> non-blocking reads. This only will read data if it's in the page cache and if
>> there is no page error (causing a re-read).
>>
>> Christoph Hellwig wrote the filesystem specify code (cifs, ofs, shm, xfs).
>>
>> Signed-off-by: Milosz Tanski <redacted>
>
> Add in the 2 hunks from the other patches, as suggested by Christoph,
> and you can add my:
>
> Reviewed-by: Jeff Moyer <redacted>

I'm aware of the 3 patch series that Christoph sent out shortly after
the previous version of the patchset. Wasn't sure what to do about it.

Christoph, should I apply your last 3 patches to the end of this tree
and send it along with the next submission? Or should I take the first
two combine them with this change and then apply RWF_DSYNC ontop of
it?

- M

-- 
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016

p: 646-253-9055
e: milosz@adfin.com

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
```
