# Re: \[PATCH 2/4\] vfs: Define new syscalls preadv2,pwritev2 - List: linux-api - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-api/2014/10/89282/t ## Re: \[PATCH 2/4\] vfs: Define new syscalls preadv2,pwritev2 - From: Jeff Moyer \ - Date: 2014-10-24 15:46:56 - Message: https://ratatoskr.run/linux-api/2014/10/89282.md ```text Milosz Tanski [ref] writes: > diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h > index 22749c1..10f8883 100644 > --- a/include/uapi/asm-generic/unistd.h > +++ b/include/uapi/asm-generic/unistd.h > @@ -213,6 +213,10 @@ __SC_COMP(__NR_pwrite64, sys_pwrite64, compat_sys_pwrite64) > __SC_COMP(__NR_preadv, sys_preadv, compat_sys_preadv) > #define __NR_pwritev 70 > __SC_COMP(__NR_pwritev, sys_pwritev, compat_sys_pwritev) > +#define __NR_preadv2 281 > +__SC_COMP(__NR_preadv2, sys_preadv2) > +#define __NR_pwritev2 282 > +__SC_COMP(__NR_pwritev2, sys_pwritev2) This looks odd. First, __SC_COMP takes 3 arguments. Second, you are going to need to implement compat wrappers for the new system calls. Cheers, Jeff ``` ## Re: \[PATCH 2/4\] vfs: Define new syscalls preadv2,pwritev2 - From: Milosz Tanski \ - Date: 2014-11-05 20:32:54 - Message: https://ratatoskr.run/linux-api/2014/11/89553.md ```text I have fixed this in the version I'm going to be resubmitting today. - Milosz On Fri, Oct 24, 2014 at 11:46 AM, Jeff Moyer [ref] wrote: > Milosz Tanski [ref] writes: > >> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h >> index 22749c1..10f8883 100644 >> --- a/include/uapi/asm-generic/unistd.h >> +++ b/include/uapi/asm-generic/unistd.h >> @@ -213,6 +213,10 @@ __SC_COMP(__NR_pwrite64, sys_pwrite64, compat_sys_pwrite64) >> __SC_COMP(__NR_preadv, sys_preadv, compat_sys_preadv) >> #define __NR_pwritev 70 >> __SC_COMP(__NR_pwritev, sys_pwritev, compat_sys_pwritev) >> +#define __NR_preadv2 281 >> +__SC_COMP(__NR_preadv2, sys_preadv2) >> +#define __NR_pwritev2 282 >> +__SC_COMP(__NR_pwritev2, sys_pwritev2) > > This looks odd. First, __SC_COMP takes 3 arguments. Second, you are > going to need to implement compat wrappers for the new system calls. > > Cheers, > Jeff -- Milosz Tanski CTO 16 East 34th Street, 15th floor New York, NY 10016 p: 646-253-9055 e: milosz@adfin.com -- To unsubscribe, send a message with 'unsubscribe linux-aio' in the body to majordomo@kvack.org. For more info on Linux AIO, see: http://www.kvack.org/aio/ Don't email: aart@kvack.org ```