# Re: \[PATCH 2/4\] vfs: Define new syscalls preadv2,pwritev2

- From: Christoph Hellwig \<hch@infradead.org\>
- Date: 2014-10-24 09:36:59 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2014/10/89274
- Thread: https://ratatoskr.run/linux-fsdevel/2014/10/89184/t.md

```text
> diff --git a/mm/filemap.c b/mm/filemap.c
> index cb7f530..45964c8 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -1735,7 +1735,7 @@ generic_file_read_iter(struct kiocb *iocb, struct iov_iter *iter)
>  		}
>  	}
>  
> -	retval = do_generic_file_read(file, ppos, iter, retval);
> +	retval = do_generic_file_read(file, ppos, iter, retval, iocb->ki_rwflags);

I think this belongs into the last patch, together with the last hunk
from the first patch.

Otherwise looks good to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org.  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
```