# Re: \[PATCH v2 5/7\] selftests/mount: change test to use ksft framework

- List: linux-api
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-api/2014/09/4339670/t

## Re: \[PATCH v2 5/7\] selftests/mount: change test to use ksft framework

- From: Eric W. Biederman \<hidden\>
- Date: 2014-09-23 23:07:52 
- Message: https://ratatoskr.run/linux-api/2014/09/4339670.md

```text
Shuah Khan [ref] writes:

> On 09/23/2014 04:41 PM, Eric W. Biederman wrote:
>> Shuah Khan [ref] writes:
>> 
>>> Change mount test to use kselftest framework to report
>>> test results.
>> 
>> Nacked-by: "Eric W. Biederman" [ref]
>> 
>> I am curious did you even run these tests?   I can't possibly see how
>> the tests would have passed with this change.  At the very least you
>> have taken this test from linear to exponential time complexity.
>> 
>
> Oops. I meant to drop this commit from the series. Sorry for the
> noise.

No problem.  Except for the unnecessary semantic change the rest of the
change looked fine.  I just wanted to make certain you didn't break my
test by accident.

Eric
```

## Re: \[PATCH v2 5/7\] selftests/mount: change test to use ksft framework

- From: Shuah Khan \<hidden\>
- Date: 2014-09-23 23:19:05 
- Message: https://ratatoskr.run/linux-api/2014/09/4339679.md

```text
On 09/23/2014 05:07 PM, Eric W. Biederman wrote:
> Shuah Khan [ref] writes:
> 
>> On 09/23/2014 04:41 PM, Eric W. Biederman wrote:
>>> Shuah Khan [ref] writes:
>>>
>>>> Change mount test to use kselftest framework to report
>>>> test results.
>>>
>>> Nacked-by: "Eric W. Biederman" [ref]
>>>
>>> I am curious did you even run these tests?   I can't possibly see how
>>> the tests would have passed with this change.  At the very least you
>>> have taken this test from linear to exponential time complexity.
>>>
>>
>> Oops. I meant to drop this commit from the series. Sorry for the
>> noise.
> 
> No problem.  Except for the unnecessary semantic change the rest of the
> change looked fine.  I just wanted to make certain you didn't break my
> test by accident.
> 

Thanks for catching it. The results didn't look right and I meant
to delay this change for later after another round of testing.
I will fix it without the unnecessary change and send it out
separately.

thanks,
-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978
```