[PATCH Resend] memfd_test: Add missing argument to printf()

Subsystems: kernel selftest framework, the rest

STALE4386d REVIEWED: 1 (0M)

1 review trailer.

2 messages, 2 authors, 2014-09-04 · open the first message on its own page

[PATCH Resend] memfd_test: Add missing argument to printf()

From: Pranith Kumar <hidden>
Date: 2014-09-04 15:58:27

Add a missing path argument buf to printf() 

Signed-off-by: Pranith Kumar <redacted>
Reviewed-by: David Herrmann <redacted>
---
 tools/testing/selftests/memfd/memfd_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
index 3634c90..c343df8 100644
--- a/tools/testing/selftests/memfd/memfd_test.c
+++ b/tools/testing/selftests/memfd/memfd_test.c
@@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
 	sprintf(buf, "/proc/self/fd/%d", fd);
 	r = open(buf, flags, mode);
 	if (r >= 0) {
-		printf("open(%s) didn't fail as expected\n");
+		printf("open(%s) didn't fail as expected\n", buf);
 		abort();
 	}
 }
-- 
2.1.0

Re: [PATCH Resend] memfd_test: Add missing argument to printf()

From: Shuah Khan <hidden>
Date: 2014-09-04 18:32:02

On 09/04/2014 09:58 AM, Pranith Kumar wrote:
quoted hunk
Add a missing path argument buf to printf() 

Signed-off-by: Pranith Kumar <redacted>
Reviewed-by: David Herrmann <redacted>
---
 tools/testing/selftests/memfd/memfd_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
index 3634c90..c343df8 100644
--- a/tools/testing/selftests/memfd/memfd_test.c
+++ b/tools/testing/selftests/memfd/memfd_test.c
@@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
 	sprintf(buf, "/proc/self/fd/%d", fd);
 	r = open(buf, flags, mode);
 	if (r >= 0) {
-		printf("open(%s) didn't fail as expected\n");
+		printf("open(%s) didn't fail as expected\n", buf);
 		abort();
 	}
 }
Thanks. I queued it for 3.17 fixes.

-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help