# Re: \[PATCH v2 3/5\]add metadata\_readahead ioctl in vfs

- From: Arnd Bergmann \<hidden\>
- Date: 2011-01-05 09:09:20 
- List: linux-api
- Page: https://ratatoskr.run/linux-api/2011/01/49778
- Thread: https://ratatoskr.run/linux-api/2011/01/49773/t.md

```text
On Wednesday 05 January 2011 03:11:36 Shaohua Li wrote:
> > Did you notice the comment above the function? ;-)
> > 
> > You should really add the new ioctls to compat_sys_ioctl, not
> > to the COMPATIBLE_IOCTL() list, in order to make the behavior
> > consistent between 32 and 64 bit user space. The main difference
> > is that all ioctl commands that are hardcoded in the functions
> > get called before trying to call the file system specific
> > .ioctl method.

> Thanks, fixed them.

The patch you posted still uses COMPATIBLE_IOCTL. Wrong patch?

	Arnd
```
