# \[PATCH v2 2/6\] xen/x86: free\_p2m\_page: use memblock\_free\_ptr() to free a virtual pointer

- From: Mike Rapoport \<hidden\>
- Date: 2021-09-30 18:51:06 
- List: linux-alpha
- Page: https://ratatoskr.run/linux-alpha/2021/09/1527459
- Thread: https://ratatoskr.run/linux-devicetree/2021/09/1527457/t.md

```text
From: Mike Rapoport <redacted>

free_p2m_page() wrongly passes a virtual pointer to memblock_free() that
treats it as a physical address.

Call memblock_free_ptr() instead that gets a virtual address to free the
memory.

Signed-off-by: Mike Rapoport <redacted>
Reviewed-by: Juergen Gross <redacted>
---
 arch/x86/xen/p2m.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index 5e6e236977c7..141bb9dbd2fb 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -197,7 +197,7 @@ static void * __ref alloc_p2m_page(void)
 static void __ref free_p2m_page(void *p)
 {
 	if (unlikely(!slab_is_available())) {
-		memblock_free((unsigned long)p, PAGE_SIZE);
+		memblock_free_ptr(p, PAGE_SIZE);
 		return;
 	}
 
-- 
2.28.0
```