# Re: \[PATCH v2 1/1\] kernel.h: Split out panic and oops helpers

- From: Sebastian Reichel \<sre@kernel.org\>
- Date: 2021-04-09 11:49:29 
- List: linux-alpha
- Page: https://ratatoskr.run/linux-alpha/2021/04/203641
- Thread: https://ratatoskr.run/linux-alpha/2021/04/203641/t.md

```text
Hi,

On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote:
> kernel.h is being used as a dump for all kinds of stuff for a long time.
> Here is the attempt to start cleaning it up by splitting out panic and
> oops helpers.
> 
> There are several purposes of doing this:
> - dropping dependency in bug.h
> - dropping a loop by moving out panic_notifier.h
> - unload kernel.h from something which has its own domain
> 
> At the same time convert users tree-wide to use new headers, although
> for the time being include new header back to kernel.h to avoid twisted
> indirected includes for existing users.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Bjorn Andersson <redacted>
> Acked-by: Mike Rapoport <redacted>
> Acked-by: Corey Minyard <redacted>
> Acked-by: Christian Brauner <redacted>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Kees Cook <redacted>
> Acked-by: Wei Liu <wei.liu@kernel.org>
> Acked-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> v2:
>  - fixed all errors with allmodconfig on x86_64 (Andrew)
>  - checked with allyesconfig on x86_64
>  - additionally grepped source code for panic notifier list usage
>    and converted all users
>  - elaborated commit message (Luis)
>  - collected given tags (incl. Andrew's SoB, see below)
> 
> I added Andrew's SoB since part of the fixes I took from him. Andrew,
> feel free to amend or tell me how you want me to do.
> 
> [...]
>  drivers/power/reset/ltc2952-poweroff.c        |  1 +
> [...]

Acked-by: Sebastian Reichel <sre@kernel.org>

-- Sebastian
```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-alpha/2021/04/203641/attachment/0) (application/pgp-signature, 833 bytes)