# Re: \[PATCH\] fix modpost when CONFIG\_ALPHA\_TSUNAMI=y

- From: Jim Faulkner \<hidden\>
- Date: 2012-02-18 22:40:01 
- List: linux-alpha
- Page: https://ratatoskr.run/linux-alpha/2012/02/3824230
- Thread: https://ratatoskr.run/linux-alpha/2012/01/3807119/t.md

```text
On Sun, Feb 19, 2012 at 11:29:34AM +1300, Michael Cree wrote:
> >  
> > +#include <linux/module.h>
> 
> Wouldn't <linux/exports.h> be better?  I seem to recall that this was a
> problem with EXPORT_SYMBOL not being defined and I see my own personal
> fix (which I had completely forgotten to send upstream) was to include
> <linux/exports.h>

core_marvel.c and core_titan.c both include <linux/module.h> in the
mainline kernel, which is why I thought it was the appropriate fix for
core_tsunami.c.

```
