Hello Andy,
This is a patch to the latest 2.5 kernel for version 0.14 of my driver. Please apply the resulting file to the linux-2.4-acpi tree also (the only change needed is for the old acpi header location).
This version is a code cleanup only, there is no end-user functionality change. By factoring out repetitive code I was able to shave about 20%, and the result is much easier to read and maintain. However, I was only able to achieve this by reverting the "seq_file" conversion which someone had made to my code. As I've explained, the interface between proc_fs and seq_file is incomplete in that userdata is not propagated. With this version I'm relying on userdata to keep my code reasonable.
Please do not apply Pavel Machek's addition of a compile-time warning to toshiba_acpi.c from his Feb 13 patch, as it no longer applies.
Regards,
-John
--
http:// if l . /