[Fwd: Re: ASL help with latest acpi and compaq presario 2800t]
From: Darren Benham <hidden>
Date: 2003-02-10 20:04:56
oops... for got to include the list... -------- Original Message -------- Subject: Re: [ACPI] ASL help with latest acpi and compaq presario 2800t From: "Darren Benham" <redacted> Date: Mon, February 10, 2003 12:01 pm To: <redacted> Ducrot Bruno said:
quoted hunk
On Sun, Feb 09, 2003 at 05:44:48PM -0700, Kevin Fenzi wrote: Try:--- dsdt.asl 2003/02/10 13:49:25 1.1 +++ dsdt.asl 2003/02/10 13:54:53@@ -1916,7 +1915,7 @@ } Method(_OFF) { If(LOr(\_SB_.C020, LEqual(0x0, 0x1))) { - Return(0x0) + /* Return(0x0) */ } C132(0x3, 0x0) }@@ -2202,7 +2201,7 @@ } Method(_OFF) { If(LOr(\_SB_.C023, LEqual(0x0, 0x1))) { - Return(0x0) + /* Return(0x0) */ } C132(0x1, 0x0) }
I question these two changes. It really does seem as if the "return" statements are to prevent the rest of the code from being executed in certain cases. Wouldn't it be wiser to leave them in and either 1) ignore the warning or 2) put "return statements at the end of the block?-- Darren -- Darren ------------------------------------------------------- This SF.NET email is sponsored by: SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See! http://www.vasoftware.com