[PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL

Subsystems: damon, memory management, the rest

STALE1771d

2 messages, 2 authors, 2021-09-26 · open the first message on its own page

[PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL

From: Colin King <hidden>
Date: 2021-09-25 21:59:15

From: Colin Ian King <redacted>

Currently a plain integer is being used to nullify the
pointer ctx->kdamond. Use NULL instead. Cleans up sparse
warning:

mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer

Signed-off-by: Colin Ian King <redacted>
---
 mm/damon/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 874558a790a0..c8665c80577a 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx)
 				nr_running_ctxs);
 		if (IS_ERR(ctx->kdamond)) {
 			err = PTR_ERR(ctx->kdamond);
-			ctx->kdamond = 0;
+			ctx->kdamond = NULL;
 		}
 	}
 	mutex_unlock(&ctx->kdamond_lock);
-- 
2.32.0

Re: [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL

From: SeongJae Park <sj@kernel.org>
Date: 2021-09-26 05:45:49

Hello Colin, thank you for the patch!
From: Colin Ian King <redacted>

Currently a plain integer is being used to nullify the
pointer ctx->kdamond. Use NULL instead. Cleans up sparse
warning:

mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer

Signed-off-by: Colin Ian King <redacted>
Reviewed-by: SeongJae Park <sj@kernel.org>

Thanks,
SJ
quoted hunk
---
 mm/damon/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/damon/core.c b/mm/damon/core.c
index 874558a790a0..c8665c80577a 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx)
 				nr_running_ctxs);
 		if (IS_ERR(ctx->kdamond)) {
 			err = PTR_ERR(ctx->kdamond);
-			ctx->kdamond = 0;
+			ctx->kdamond = NULL;
 		}
 	}
 	mutex_unlock(&ctx->kdamond_lock);
-- 
2.32.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help