[PATCH] scsi: qedi: add missing curly braces
From: Dan Carpenter <hidden>
Date: 2021-08-12 06:33:28
Also in:
linux-scsi
Subsystem:
iscsi, qlogic ql41xxx iscsi driver, scsi subsystem, the rest · Maintainers:
Lee Duncan, Chris Leech, Mike Christie, Nilesh Javali, Manish Rangankar, "James E.J. Bottomley", "Martin K. Petersen", Linus Torvalds
This if statement has missing curly braces so it will always report an
error even when the call to ->offload_conn() succeeded.
Fixes: 072ae05a044f ("scsi: qedi: Add support for fastpath doorbell recovery")
Signed-off-by: Dan Carpenter <redacted>
---
drivers/scsi/qedi/qedi_iscsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
index 8ac8aabc1ef6..c5260429c637 100644
--- a/drivers/scsi/qedi/qedi_iscsi.c
+++ b/drivers/scsi/qedi/qedi_iscsi.c@@ -599,7 +599,7 @@ static int qedi_iscsi_offload_conn(struct qedi_endpoint *qedi_ep) } rval = qedi_ops->offload_conn(qedi->cdev, qedi_ep->handle, conn_info); - if (rval) + if (rval) { /* delete doorbell from doorbell recovery mechanism */ rval = qedi_ops->common->db_recovery_del(qedi->cdev, qedi_ep->p_doorbell,
@@ -607,6 +607,7 @@ static int qedi_iscsi_offload_conn(struct qedi_endpoint *qedi_ep) QEDI_ERR(&qedi->dbg_ctx, "offload_conn returned %d, ep=%p\n", rval, qedi_ep); + } kfree(conn_info); return rval;
--
2.20.1