[patch] irqchip: irq-alpine-msi: releasing the wrong variable on error
flat view
DORMANTno replies
From: Dan Carpenter <hidden>
Date: 2016-03-11 08:15:17
Also in:
lkml
Subsystem:
arm/annapurna labs alpine architecture, irqchip drivers, the rest · Maintainers:
Antoine Tenart, Thomas Gleixner, Linus Torvalds
The "msi_domain" variable is NULL here so it leads to a NULL
dereference. It looks like we actually intended to free
"middle_domain".
Fixes: e6b78f2c3e14 ('irqchip: Add the Alpine MSIX interrupt controller')
Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/irqchip/irq-alpine-msi.c b/drivers/irqchip/irq-alpine-msi.c
index f871272..2538425 100644
--- a/drivers/irqchip/irq-alpine-msi.c
+++ b/drivers/irqchip/irq-alpine-msi.c@@ -220,7 +220,7 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv, middle_domain); if (!msi_domain) { pr_err("Failed to create MSI domain\n"); - irq_domain_remove(msi_domain); + irq_domain_remove(middle_domain); return -ENOMEM; }