[patch] ACPI: free memory on an error path
DORMANTno replies
From: Dan Carpenter <hidden>
Date: 2012-09-25 07:01:10
Also in:
linux-acpi
Subsystem:
acpi, the rest · Maintainers:
"Rafael J. Wysocki", Linus Torvalds
We should free "physical_node" if before returning the error code. Signed-off-by: Dan Carpenter <redacted> --- Only needed in linux-next. Introduced in 1033f9041d5 "ACPI: Allow ACPI binding with USB-3.0 hub".
diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c
index d1a2d74..cfeecac 100644
--- a/drivers/acpi/glue.c
+++ b/drivers/acpi/glue.c@@ -159,7 +159,7 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle) if (physical_node->node_id >= ACPI_MAX_PHYSICAL_NODE) { retval = -ENOSPC; mutex_unlock(&acpi_dev->physical_node_lock); - goto err; + goto free_node; } set_bit(physical_node->node_id, acpi_dev->physical_node_id_bitmap);
@@ -185,6 +185,8 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle) return 0; +free_node: + kfree(physical_node); err: put_device(dev); return retval;