[patch] drm/nouveau/dp: nouveau_dp_link_train() returns bool
From: Dan Carpenter <hidden>
Date: 2012-01-15 11:31:09
Also in:
dri-devel
Subsystem:
drm driver for nvidia geforce/quadro gpus, drm drivers, drm drivers and misc gpu patches, the rest · Maintainers:
Lyude Paul, Danilo Krummrich, David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Linus Torvalds
The caller doesn't check the return value, but this function returns a bool so static checkers complain when we return a negative error code. Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/gpu/drm/nouveau/nouveau_dp.c
index 9b93b70..dcffd13 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dp.c
+++ b/drivers/gpu/drm/nouveau/nouveau_dp.c@@ -573,7 +573,7 @@ nouveau_dp_link_train(struct drm_encoder *encoder, u32 datarate) dp.table = nouveau_dp_bios_data(dev, nv_encoder->dcb, &dp.entry); if (!dp.table) - return -EINVAL; + return false; dp.dcb = nv_encoder->dcb; dp.crtc = nv_crtc->index;