[patch 2/2] Staging: iio/light/tsl2563: fix compile warning

Subsystems: iio subsystem and drivers, staging - industrial io, staging subsystem, the rest

STALE5487d

2 messages, 2 authors, 2011-10-06 · open the first message on its own page

[patch 2/2] Staging: iio/light/tsl2563: fix compile warning

From: Dan Carpenter <hidden>
Date: 2011-10-06 06:15:36

This fixes a compile warning:
drivers/staging/iio/light/tsl2563.c:696:2:
	warning: initialization from incompatible pointer type [enabled by default]
drivers/staging/iio/light/tsl2563.c:696:2:
	warning: (near initialization for ‘tsl2563_info.write_event_value’) [enabled by default]

The tsl2563_write_thresh() function returns zero on success and error
codes on failure, so nothing is lost by making the return type int
instead of ssize_t.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
index 8977f58..a5e08b3 100644
--- a/drivers/staging/iio/light/tsl2563.c
+++ b/drivers/staging/iio/light/tsl2563.c
@@ -569,7 +569,7 @@ static int tsl2563_read_thresh(struct iio_dev *indio_dev,
 	return 0;
 }
 
-static ssize_t tsl2563_write_thresh(struct iio_dev *indio_dev,
+static int tsl2563_write_thresh(struct iio_dev *indio_dev,
 				  u64 event_code,
 				  int val)
 {

Re: [patch 2/2] Staging: iio/light/tsl2563: fix compile warning

From: Jonathan Cameron <hidden>
Date: 2011-10-06 11:03:04

On 10/06/11 07:15, Dan Carpenter wrote:
This fixes a compile warning:
drivers/staging/iio/light/tsl2563.c:696:2:
	warning: initialization from incompatible pointer type [enabled by default]
drivers/staging/iio/light/tsl2563.c:696:2:
	warning: (near initialization for ‘tsl2563_info.write_event_value’) [enabled by default]

The tsl2563_write_thresh() function returns zero on success and error
codes on failure, so nothing is lost by making the return type int
instead of ssize_t.
You are quite right. This is a silly cut and paste mistake on my part.
Thanks.
Signed-off-by: Dan Carpenter <redacted>
Acked-by: Jonathan Cameron <redacted>
quoted hunk
diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
index 8977f58..a5e08b3 100644
--- a/drivers/staging/iio/light/tsl2563.c
+++ b/drivers/staging/iio/light/tsl2563.c
@@ -569,7 +569,7 @@ static int tsl2563_read_thresh(struct iio_dev *indio_dev,
 	return 0;
 }
 
-static ssize_t tsl2563_write_thresh(struct iio_dev *indio_dev,
+static int tsl2563_write_thresh(struct iio_dev *indio_dev,
 				  u64 event_code,
 				  int val)
 {

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help