[PATCH] fs: removing unused fops from struct char_device_struct

Subsystems: filesystems (vfs and infrastructure), the rest

STALE6812d

4 messages, 2 authors, 2008-02-21 · open the first message on its own page

[PATCH] fs: removing unused fops from struct char_device_struct

From: Jiri Olsa <hidden>
Date: 2008-02-20 20:58:44

Hi,

seems struct char_device_struct::fops is no longer used, removing it.
I checked with "make allyesconfig" and got proper compile.

Signed-off-by: Jiri Olsa <redacted>
---
 fs/char_dev.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/char_dev.c b/fs/char_dev.c
index c3bfa76..e4527fb 100644
--- a/fs/char_dev.c
+++ b/fs/char_dev.c
@@ -55,7 +55,6 @@ static struct char_device_struct {
 	unsigned int baseminor;
 	int minorct;
 	char name[64];
-	struct file_operations *fops;
 	struct cdev *cdev;		/* will die */
 } *chrdevs[CHRDEV_MAJOR_HASH_SIZE];
 

Re: [PATCH] fs: removing unused fops from struct char_device_struct

From: Greg KH <hidden>
Date: 2008-02-21 00:19:14

On Wed, Feb 20, 2008 at 09:57:23PM +0100, Jiri Olsa wrote:
Hi,

seems struct char_device_struct::fops is no longer used, removing it.
I checked with "make allyesconfig" and got proper compile.

Signed-off-by: Jiri Olsa <redacted>
Hm, why send this to me?

Did I make the mistake of touching this file last?  Hm, nope, someone
else touched it after I did, I'm safe :)

Seriously, I have no problem with this, but it should probably go
through Andrew.

thanks,

greg k-h

Re: [PATCH] fs: removing unused fops from struct char_device_struct

From: Jiri Olsa <hidden>
Date: 2008-02-21 06:09:15

oops, sorry... for some reason I though you were the guy :)
I'll resend

jirka


Greg KH wrote:
On Wed, Feb 20, 2008 at 09:57:23PM +0100, Jiri Olsa wrote:
quoted
Hi,

seems struct char_device_struct::fops is no longer used, removing it.
I checked with "make allyesconfig" and got proper compile.

Signed-off-by: Jiri Olsa <redacted>
Hm, why send this to me?

Did I make the mistake of touching this file last?  Hm, nope, someone
else touched it after I did, I'm safe :)

Seriously, I have no problem with this, but it should probably go
through Andrew.

thanks,

greg k-h

[PATCH] fs: removing unused fops from struct char_device_struct -

From: Jiri Olsa <hidden>
Date: 2008-02-21 06:13:22

Hi,

seems char_device_struct::fops is no longer used, removing it.
I checked with "make allyesconfig" and got proper build.

Signed-off-by: Jiri Olsa <redacted>
---
 fs/char_dev.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/char_dev.c b/fs/char_dev.c
index c3bfa76..e4527fb 100644
--- a/fs/char_dev.c
+++ b/fs/char_dev.c
@@ -55,7 +55,6 @@ static struct char_device_struct {
 	unsigned int baseminor;
 	int minorct;
 	char name[64];
-	struct file_operations *fops;
 	struct cdev *cdev;		/* will die */
 } *chrdevs[CHRDEV_MAJOR_HASH_SIZE];
 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help