Re: [Intel-gfx] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if... | intel-gfx

[PATCH v2 0/2] Cleanups for the nomodeset kernel command line parameter logic · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-04
[PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Jani Nikula <jani.nikula@linux.intel.com> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Sam Ravnborg <hidden> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Jani Nikula <jani.nikula@linux.intel.com> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Sam Ravnborg <hidden> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Jani Nikula <jani.nikula@linux.intel.com> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Jani Nikula <jani.nikula@linux.intel.com> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-04
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Thomas Zimmermann <tzimmermann@suse.de> · 2021-11-05
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-05
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Jani Nikula <jani.nikula@linux.intel.com> · 2021-11-05
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-05
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Thomas Zimmermann <tzimmermann@suse.de> · 2021-11-05
Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled · Thomas Zimmermann <tzimmermann@suse.de> · 2021-11-05
[PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-04
Re: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem · Thomas Zimmermann <tzimmermann@suse.de> · 2021-11-05
Re: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem · Jani Nikula <jani.nikula@linux.intel.com> · 2021-11-05
Re: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem · Thomas Zimmermann <tzimmermann@suse.de> · 2021-11-05
Re: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-05
Re: [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem · Javier Martinez Canillas <javierm@redhat.com> · 2021-11-05
[Intel-gfx] ✗ Fi.CI.BUILD: failure for Cleanups for the nomodeset kernel command line parameter logic (rev4) · Patchwork <hidden> · 2021-11-04

Re: [Intel-gfx] [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled

From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2021-11-04 16:44:16
Also in: amd-gfx, dri-devel, lkml, nouveau

On 11/4/21 17:24, Jani Nikula wrote:

[snip]

quoted

index ab2295dd4500..45cb3e540eff 100644

--- a/drivers/gpu/drm/i915/i915_module.c
+++ b/drivers/gpu/drm/i915/i915_module.c

@@ -18,9 +18,12 @@
 #include "i915_selftest.h"
 #include "i915_vma.h"
 
+static const struct drm_driver driver;
+

No, this makes absolutely no sense, and will also oops on nomodeset.

Ups, sorry about that. For some reason I thought that it was defined in
the same compilation unit, but I noticed now that it is in i915_drv.c.

BR,
Jani.

Best regards,
-- 
Javier Martinez Canillas
Linux Engineering
Red Hat

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help