Reviews by lyude@redhat.com · igt-dev

All review-attestation trailers (Reviewed-by / Acked-by / Tested-by / Reported-by / Suggested-by / Co-developed-by / Reported-and-tested-by) by this address on the igt-dev archive.

100 attestations · capped at 100 most-recent. (9 Acked-by, 91 Reviewed-by)

• STALE168d REVIEWED: 3 (3M) Re: [PATCH i-g-t 3/5] tests/nouveau_crc: Use igt_first_crtc() instead of igt_crtc_for_pipe()
  2026-03-06 · Reviewed-by
• STALE168d REVIEWED: 3 (3M) Re: [PATCH i-g-t 1/5] tests/nouveau_crc: Extract {setup,cleanup}_test()
  2026-03-06 · Acked-by
• STALE443d REVIEWED: 4 (3M) [PATCH i-g-t v5 3/9] lib/igt_nouveau: fix print formatting for 32-bit compilation
  2025-06-03 · Reviewed-by
• STALE445d REVIEWED: 3 (3M) Re: [PATCH i-g-t v4 3/9] lib/igt_nouveau: fixup print formatting for files in lib
  2025-05-27 · Reviewed-by
• STALE1017d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t v1 4/5] drm-uapi/nouveau: sync with drm-next
  2023-11-08 · Reviewed-by
• STALE1150d REVIEWED: 3 (3M) [igt-dev] [V4 i-g-t 08/24] tests/nouveau_crc: Close the fd before exit
  2023-06-26 · Reviewed-by
• STALE1156d REVIEWED: 3 (3M) [igt-dev] [V3 i-g-t 08/23] tests/nouveau_crc: Close the fd before exit
  2023-06-22 · Reviewed-by
• STALE1163d REVIEWED: 3 (3M) Re: [igt-dev] [i-g-t 07/20] tests/nouveau_crc: Close the fd before exit
  2023-05-16 · Reviewed-by
• DORMANTno replies REVIEWED: 3 (3M) Re: [igt-dev] [PATCH] Refactor Display Outputs to handle MST Connectors.
  2022-10-25 · Reviewed-by
• DORMANTno replies REVIEWED: 3 (3M) Re: [igt-dev] [PATCH] chamelium: Get connector After plug to get EDID
  2022-10-21 · Reviewed-by
• DORMANTno replies REVIEWED: 3 (3M) Re: [igt-dev] [PATCH] Chamelium: Handle getting port connector if it's MST.
  2022-10-17 · Reviewed-by
• DORMANTno replies REVIEWED: 3 (3M) Re: [igt-dev] [PATCH v2] lib/chamelium: Use MST Path property to reprobe an MST connector.
  2022-08-22 · Reviewed-by
• STALE1472d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t] tests/chamelium: Move Chamelium tests to their own folder
  2022-08-10 · Acked-by
• STALE1472d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t] tests/chamelium: Move Chamelium tests to their own folder
  2022-08-10 · Acked-by
• STALE1472d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t] tests/chamelium: Move Chamelium tests to their own folder
  2022-08-10 · Reviewed-by
• STALE1971d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t] lib: Don't use libdrm_nouveau if not found
  2021-03-29 · Reviewed-by
• STALE1975d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t 3/3] tests/kms_cursor_crc: Test maximum cursor size
  2021-03-24 · Reviewed-by
• STALE1977d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t] Revert "tests/kms_plane: Don't unset primary_fb when testing other planes"
  2021-03-22 · Reviewed-by
• STALE2102d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t v4 2/2] tests/kms_addfb_basic: add vendor-specific errno assertions
  2020-11-18 · Reviewed-by
• STALE2102d REVIEWED: 3 (3M) [igt-dev] [PATCH i-g-t v4 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
  2020-11-18 · Reviewed-by
• STALE2102d REVIEWED: 3 (3M) [igt-dev] [PATCH i-g-t v3 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
  2020-11-17 · Reviewed-by
• STALE2102d REVIEWED: 3 (3M) [igt-dev] [PATCH i-g-t v2 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
  2020-11-16 · Reviewed-by
• STALE2102d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_addfb_basic: Mark Intel-only tests as such
  2020-11-13 · Reviewed-by
• STALE2235d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t 3/3] lib/igt_chamelium: Wait for connectors after replugging them at exit
  2020-07-07 · Reviewed-by
• DORMANTno replies REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t] lib/igt_chamelium: Wait for connectors after replugging them at exit
  2020-07-06 · Reviewed-by
• STALE2660d REVIEWED: 3 (3M) [igt-dev] [PATCH i-g-t v2] tests/kms_chamelium: Make sure we wait for each connectors' hotplug event
  2019-05-08 · Reviewed-by
• STALE2660d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t] tests/kms_chamelium: Make sure we wait for each connectors' hotplug event
  2019-05-07 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 22/22] chamelium: Add a display test for randomized planes
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 21/22] chamelium: Move the YUV tests over to the checkerboard checking method
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 20/22] lib/igt_chamelium: Hook-in checkerboard comparison method in helpers
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 19/22] lib/igt_frame: Add a checkerboard frame comparison method
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 18/22] lib/igt_chamelium: Generalize the frame match helper with check type
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 17/22] lib/igt_chamelium: Split frames dump logic and rework surroundings
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 16/22] lib/igt_chamelium: Fixup resources liberation in comparison helpers
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 15/22] lib/igt_kms: Add helpers to count and iterate planes from output
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 14/22] lib/igt_kms: Add helpers to count and iterate planes from pipe
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 13/22] lib/igt_fb: Support converting to VC4 modifiers in igt_fb_convert
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 11/22] lib/igt_vc4: Add helpers for converting linear to SAND-tiled buffers
  2019-02-22 · Acked-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 12/22] lib/igt_fb: Pass the modifier to igt_fb_convert helpers
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 10/22] lib/igt_vc4: Add helpers for converting linear to T-tiled RGB buffers
  2019-02-22 · Acked-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 09/22] lib/igt_fb: Add a helper to fill-in the available DRM formats
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 07/22] lib/igt_fb: Add a stride-provisioned fashion of igt_fb_convert
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 08/22] lib/igt_fb: Add a helper to retreive the plane bpp for a given format
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 06/22] lib/igt_fb: Allow interpreting the tile height as a stride equivalent
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 05/22] lib/igt_fb: Add support for VC4 SAND tiling modes
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 04/22] lib/igt_fb: Add support for allocating T-tiled VC4 buffers
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 03/22] lib/igt_fb: Refactor create_bo_for_fb to prepare for VC4 support
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 01/22] lib: drmtest: Add helpers to check and require the VC4 driver
  2019-02-22 · Reviewed-by
• STALE2737d REVIEWED: 4 (3M) [igt-dev] [PATCH RESEND i-g-t v6 02/22] lib/igt_fb: Add checks on i915 for i915-specific tiled buffer allocation
  2019-02-22 · Reviewed-by
• DORMANTno replies REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 17/22] lib/igt_chamelium: Split frames dump logic and rework surroundings
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 16/22] lib/igt_chamelium: Fixup resources liberation in comparison helpers
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 15/22] lib/igt_kms: Add helpers to count and iterate planes from output
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 14/22] lib/igt_kms: Add helpers to count and iterate planes from pipe
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 13/22] lib/igt_fb: Support converting to VC4 modifiers in igt_fb_convert
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 12/22] lib/igt_fb: Pass the modifier to igt_fb_convert helpers
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 11/22] lib/igt_vc4: Add helpers for converting linear to SAND-tiled buffers
  2019-02-22 · Acked-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 10/22] lib/igt_vc4: Add helpers for converting linear to T-tiled RGB buffers
  2019-02-22 · Acked-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 09/22] lib/igt_fb: Add a helper to fill-in the available DRM formats
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 08/22] lib/igt_fb: Add a helper to retreive the plane bpp for a given format
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 07/22] lib/igt_fb: Add a stride-provisioned fashion of igt_fb_convert
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 06/22] lib/igt_fb: Allow interpreting the tile height as a stride equivalent
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 05/22] lib/igt_fb: Add support for VC4 SAND tiling modes
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 04/22] lib/igt_fb: Add support for allocating T-tiled VC4 buffers
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 03/22] lib/igt_fb: Refactor create_bo_for_fb to prepare for VC4 support
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 02/22] lib/igt_fb: Add checks on i915 for i915-specific tiled buffer allocation
  2019-02-22 · Reviewed-by
• STALE2738d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 01/22] lib: drmtest: Add helpers to check and require the VC4 driver
  2019-02-22 · Reviewed-by
• STALE2718d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t] tests/kms_lease: exercise uevent
  2019-02-21 · Reviewed-by
• STALE2718d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t 1/9] tests/kms_lease: Add invalid planes tests
  2019-02-20 · Reviewed-by
• DORMANTno replies REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t v5 03/22] lib/igt_fb: Refactor create_bo_for_fb to prepare for VC4 support
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 22/22] chamelium: Add a display test for randomized planes
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 21/22] chamelium: Move the YUV tests over to the checkerboard checking method
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 20/22] lib/igt_chamelium: Hook-in checkerboard comparison method in helpers
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 19/22] lib/igt_frame: Add a checkerboard frame comparison method
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 18/22] lib/igt_chamelium: Generalize the frame match helper with check type
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 17/22] lib/igt_chamelium: Split frames dump logic and rework surroundings
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 16/22] lib/igt_chamelium: Fixup resources liberation in comparison helpers
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 15/22] lib/igt_kms: Add helpers to count and iterate planes from output
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 14/22] lib/igt_kms: Add helpers to count and iterate planes from pipe
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 13/22] lib/igt_fb: Support converting to VC4 modifiers in igt_fb_convert
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 12/22] lib/igt_fb: Pass the modifier to igt_fb_convert helpers
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 11/22] lib/igt_vc4: Add helpers for converting linear to SAND-tiled buffers
  2019-02-20 · Acked-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 10/22] lib/igt_vc4: Add helpers for converting linear to T-tiled RGB buffers
  2019-02-20 · Acked-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 09/22] lib/igt_fb: Add a helper to fill-in the available DRM formats
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 08/22] lib/igt_fb: Add a helper to retreive the plane bpp for a given format
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 07/22] lib/igt_fb: Add a stride-provisioned fashion of igt_fb_convert
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 06/22] lib/igt_fb: Allow interpreting the tile height as a stride equivalent
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 05/22] lib/igt_fb: Add support for VC4 SAND tiling modes
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 04/22] lib/igt_fb: Add support for allocating T-tiled VC4 buffers
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 02/22] lib/igt_fb: Add checks on i915 for i915-specific tiled buffer allocation
  2019-02-20 · Reviewed-by
• STALE2739d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v5 01/22] lib: drmtest: Add helpers to check and require the VC4 driver
  2019-02-20 · Reviewed-by
• STALE2748d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t v6 03/10] igt: fb: Account for all planes bpp
  2019-02-08 · Reviewed-by
• STALE2748d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t v6 02/10] igt: fb: Add size checks and recalculation before dumb allocation
  2019-02-08 · Reviewed-by
• STALE2748d REVIEWED: 3 (3M) Re: [igt-dev] [PATCH i-g-t v6 01/10] igt: fb: Refactor dumb buffer allocation path
  2019-02-08 · Reviewed-by
• STALE2748d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 04/10] igt: fb: Don't pass the stride when allocating a dumb, multi-planar buffer
  2019-02-08 · Reviewed-by
• STALE2748d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 05/10] igt: fb: Clear YUV dumb buffers
  2019-02-08 · Reviewed-by
• STALE2748d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 09/10] igt: tests: chamelium: Convert VGA tests to do_test_display
  2019-02-08 · Reviewed-by
• STALE2748d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 07/10] igt: fb: Add a bunch of new YUV formats
  2019-02-08 · Reviewed-by
• STALE2748d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 08/10] igt: tests: chamelium: Start to unify tests
  2019-02-08 · Reviewed-by
• STALE2748d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 06/10] igt: fb: Rework YUV i915 allocation path
  2019-02-08 · Reviewed-by
• STALE2748d REVIEWED: 4 (3M) [igt-dev] [PATCH i-g-t v6 10/10] igt: tests: chamelium: Add YUV formats tests
  2019-02-08 · Reviewed-by