-----Original Message-----
From: igt-dev <redacted> On Behalf Of
Bhanuprakash Modem
Sent: Tuesday, August 13, 2024 11:09 AM
To: igt-dev@lists.freedesktop.org
Cc: Modem, Bhanuprakash <redacted>
Subject: [i-g-t 4/4] tests/kms_vrr: Add more logs to skips
Debugging would be easier if we had logs available for test failures and skips. This
patch adds print statements at crucial points to provide better insights.
Signed-off-by: Bhanuprakash Modem <redacted>
---
tests/kms_vrr.c | 29 +++++++++++++++++++++--------
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c index 4fa3df417..36a22eebe
100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -879,12 +879,14 @@ static bool output_constraint(data_t *data,
igt_output_t *output, uint32_t flags
data->debugfs_fd = igt_debugfs_dir(data->drm_fd);
if ((flags & (TEST_SEAMLESS_VRR | TEST_SEAMLESS_DRRS | TEST_CMRR
| TEST_LINK_OFF)) &&
- output->config.connector->connector_type !=
DRM_MODE_CONNECTOR_eDP)
+ output->config.connector->connector_type !=
DRM_MODE_CONNECTOR_eDP) {
+ igt_info("%s: Connected panel is not eDP.\n",
+igt_output_name(output));
return false;
+ }
if ((flags & TEST_SEAMLESS_DRRS) &&
!intel_output_has_drrs(data->drm_fd, output)) {
- igt_info("Selected panel won't support DRRS.\n");
+ igt_info("%s: Won't support DRRS.\n",
igt_output_name(output));
return false;
}
@@ -894,7 +896,7 @@ static bool output_constraint(data_t *data, igt_output_t
*output, uint32_t flags
psr_disable(data->drm_fd, data->debugfs_fd, NULL);
if (igt_get_i915_edp_lobf_status(data->drm_fd, output->name)) {
- igt_info("LOBF not supported. \n");
+ igt_info("%s: LOBF not supported.\n",
igt_output_name(output));
return false;
}
}@@ -911,8 +913,11 @@ static bool output_constraint(data_t *data, igt_output_t
*output, uint32_t flags
* - Limit the vrr_max range with the override mode vrefresh.
*/
data->switch_modes[HIGH_RR_MODE] =
output_mode_with_maxrate(output, data->range.max);
- if (data->switch_modes[HIGH_RR_MODE].vrefresh < data->range.min)
+ if (data->switch_modes[HIGH_RR_MODE].vrefresh < data->range.min) {
+ igt_info("%s: Can't find a valid mode with refresh rate (%d)
greater than Vmin (%d).\n",
+ igt_output_name(output), data-quoted
switch_modes[HIGH_RR_MODE].vrefresh,
+data->range.min);