# Re: \[PATCH 0/8\] ci: consolidate test variables

- From: Toon Claes \<hidden\>
- Date: 2026-10-28 14:41:02 
- List: git
- Page: https://ratatoskr.run/git/2026/10/17817441
- Thread: https://ratatoskr.run/git/2026/10/17808918/t.md

```text
Jeff King [ref] writes:

> On Tue, Oct 27, 2026 at 09:18:20AM +0100, Patrick Steinhardt wrote:
>
>> this patch series consolidates our test variables as a follow up on the
>> discussions in [1].
>
> Thanks for following up. 1-7 seem obviously good to me.

Yes, 1-7 look good and are pretty much noncontroversial.

> I'm lukewarm on the final patch (and left a comment there), but if you
> really love it, I can live with it. :)

I understand the stance of both of you. To be honest, I don't really
have an opinion. The cleanest fix probably would be to split the build
flags from test flags, because it's a mix now and Peff prefers to have
them all fixed, while Patrick likes to change them run-by-run. Although,
that would probably lead this patch series beyond their intentions.

-- 
Laters,
Toon
```