Re: [GSoC PATCH] t9200: use helpers to replace test -f <path> and test -d <path>

2 messages, 2 authors, 2026-03-09 · open the first message on its own page

Re: [GSoC PATCH] t9200: use helpers to replace test -f <path> and test -d <path>

From: Junio C Hamano <hidden>
Date: 2026-03-09 15:20:32

Pablo Sabater [off-list ref] writes:
Replaced 'test -f' and 'test -d' with 'test_path_is_file' and 'test_path_is_dir'

I've used 'git grep "test -f" t/t9*.sh' to find a file without the fix done as specified on the microproject information
I've done '9*' because the ones I've found first had already fix patches.
I've taken as example another patch sent 't4131' from Junio C Hamano https://lore.kernel.org/git/xmqq1rpodn25.fsf@gitster.c.googlers.com/#r
After studying Documentation/{SubmittingPatches,CodingGuidelines},
use the list archive to find what instructions GSoC participant
candidates have received regarding the proposed log messages in
their microproject submissions.

Thanks.

Re: [GSoC PATCH] t9200: use helpers to replace test -f <path> and test -d <path>

From: Pablo <hidden>
Date: 2026-03-09 15:39:38

After studying Documentation/{SubmittingPatches,CodingGuidelines},
use the list archive to find what instructions GSoC participant
candidates have received regarding the proposed log messages in
their microproject submissions.
Thanks for the feedback, I'll work on that right now, once done I'll send a v2.

Pablo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help