Re: [PATCH v3 2/3] add-patch: Allow interfile navigation when selecting hunks

2 messages, 2 authors, 2026-02-06 · open the first message on its own page

Re: [PATCH v3 2/3] add-patch: Allow interfile navigation when selecting hunks

From: Junio C Hamano <hidden>
Date: 2026-02-06 18:35:55

Abraham Samuel Adekunle [off-list ref] writes:
-		} else if (s->answer.buf[0] == 'K') {
+		} else if (s->s.no_auto_advance && s->answer.buf[0] == '>') {
+			if (permitted & ALLOW_GOTO_NEXT_FILE) {
+				ret = NEXT_FILE;
+...
+				continue;
+			}
+		}
+		else if (s->answer.buf[0] == 'K') {
This funny-looking diff is a sign that the coding guideline was
followed in the preimage but not in the postimage, by splitting
the "} else if (condition) {" into two lines for 'K'.

Re: [PATCH v3 2/3] add-patch: Allow interfile navigation when selecting hunks

From: Samuel Abraham <hidden>
Date: 2026-02-06 20:22:38

On Fri, Feb 6, 2026 at 7:35 PM Junio C Hamano [off-list ref] wrote:
Abraham Samuel Adekunle [off-list ref] writes:
quoted
-             } else if (s->answer.buf[0] == 'K') {
+             } else if (s->s.no_auto_advance && s->answer.buf[0] == '>') {
+                     if (permitted & ALLOW_GOTO_NEXT_FILE) {
+                             ret = NEXT_FILE;
+...
+                             continue;
+                     }
+             }
+             else if (s->answer.buf[0] == 'K') {
This funny-looking diff is a sign that the coding guideline was
followed in the preimage but not in the postimage, by splitting
the "} else if (condition) {" into two lines for 'K'.
Sorry, I will fix it
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help