From: David Aguilar <hidden> Date: 2025-08-26 16:04:41
The "cargo build" invocations in contrib/ cannot be run in parallel.
"make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings
and can trigger ld errors during the build.
The build errors are caused by two inner "make" invocations getting
triggered concurrently: once inside of libgit-sys and another inside of
libgit-rs.
Signed-off-by: David Aguilar <redacted>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Tue, Aug 26, 2025 at 9:04 AM David Aguilar [off-list ref] wrote:
quoted hunk
The "cargo build" invocations in contrib/ cannot be run in parallel.
"make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings
and can trigger ld errors during the build.
The build errors are caused by two inner "make" invocations getting
triggered concurrently: once inside of libgit-sys and another inside of
libgit-rs.
Signed-off-by: David Aguilar <redacted>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I'm not familiar enough with make or with rust, but do we need to
depend on both of these here? Wouldn't it be sufficient to say
libgit-rs depends on libgit-sys, and only explicitly depend on
libgit-rs in `all::`?
On August 26, 2025 1:45 PM, Kyle Lippincott wrote:
On Tue, Aug 26, 2025 at 9:04 AM David Aguilar [off-list ref] wrote:
quoted
The "cargo build" invocations in contrib/ cannot be run in parallel.
"make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings
and can trigger ld errors during the build.
The build errors are caused by two inner "make" invocations getting
triggered concurrently: once inside of libgit-sys and another inside
of libgit-rs.
Signed-off-by: David Aguilar <redacted>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I'm not familiar enough with make or with rust, but do we need to depend on both
of these here? Wouldn't it be sufficient to say libgit-rs depends on libgit-sys, and
only explicitly depend on libgit-rs in `all::`?
Not all platforms can build libgit-rs, so inserting it into as a required component is not
a particularly friendly idea.
On Tue, Aug 26, 2025 at 10:53 AM [off-list ref] wrote:
On August 26, 2025 1:45 PM, Kyle Lippincott wrote:
quoted
On Tue, Aug 26, 2025 at 9:04 AM David Aguilar [off-list ref] wrote:
quoted
The "cargo build" invocations in contrib/ cannot be run in parallel.
"make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock warnings
and can trigger ld errors during the build.
The build errors are caused by two inner "make" invocations getting
triggered concurrently: once inside of libgit-sys and another inside
of libgit-rs.
Signed-off-by: David Aguilar <redacted>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I'm not familiar enough with make or with rust, but do we need to depend on both
of these here? Wouldn't it be sufficient to say libgit-rs depends on libgit-sys, and
only explicitly depend on libgit-rs in `all::`?
Not all platforms can build libgit-rs, so inserting it into as a required component is not
a particularly friendly idea.
That's not what I was suggesting. This is already in an `ifdef`, and
the line I was quoting was changing `all:: libgit-sys libgit-rs` to
`all:: libgit-sys .WAIT libgit-rs`. I'm wondering if we can instead
split the `libgit-sys libgit-rs:` from a few lines earlier into
`libgit-sys:` and `libgit-rs: libgit-sys` and then change this all
line to `all:: libgit-rs` (still behind `ifdef INCLUDE_LIBGIT_RS`).
On August 26, 2025 2:03 PM, Kyle Lippincott wrote:
On Tue, Aug 26, 2025 at 10:53 AM [off-list ref] wrote:
quoted
On August 26, 2025 1:45 PM, Kyle Lippincott wrote:
quoted
On Tue, Aug 26, 2025 at 9:04 AM David Aguilar [off-list ref] wrote:
quoted
The "cargo build" invocations in contrib/ cannot be run in parallel.
"make -JN" with INCLUDE_LIBGIT_RS enabled causes cargo lock
warnings and can trigger ld errors during the build.
The build errors are caused by two inner "make" invocations getting
triggered concurrently: once inside of libgit-sys and another
inside of libgit-rs.
Signed-off-by: David Aguilar <redacted>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I'm not familiar enough with make or with rust, but do we need to
depend on both of these here? Wouldn't it be sufficient to say
libgit-rs depends on libgit-sys, and only explicitly depend on libgit-rs in `all::`?
Not all platforms can build libgit-rs, so inserting it into as a
required component is not a particularly friendly idea.
That's not what I was suggesting. This is already in an `ifdef`, and the line I was
quoting was changing `all:: libgit-sys libgit-rs` to
`all:: libgit-sys .WAIT libgit-rs`. I'm wondering if we can instead split the `libgit-sys
libgit-rs:` from a few lines earlier into `libgit-sys:` and `libgit-rs: libgit-sys` and then
change this all line to `all:: libgit-rs` (still behind `ifdef INCLUDE_LIBGIT_RS`).
Thank you. I appreciate this and the clarity it provides.
Randall