DORMANTno replies

[PATCH] pretty: avoid double negative in format_commit_item()

From: René Scharfe <hidden>
Date: 2023-07-07 18:46:32
Subsystem: the rest · Maintainer: Linus Torvalds

Test for equality with no_flush, which has enough negation already.  Get
rid of the unnecessary parentheses while at it.

Signed-off-by: René Scharfe <redacted>
---
 pretty.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pretty.c b/pretty.c
index 7862be105d..81cdc9f2cd 100644
--- a/pretty.c
+++ b/pretty.c
@@ -1855,10 +1855,10 @@ static size_t format_commit_item(struct strbuf *sb, /* in UTF-8 */
 	}

 	orig_len = sb->len;
-	if ((context)->flush_type != no_flush)
-		consumed = format_and_pad_commit(sb, placeholder, context);
-	else
+	if (context->flush_type == no_flush)
 		consumed = format_commit_one(sb, placeholder, context);
+	else
+		consumed = format_and_pad_commit(sb, placeholder, context);
 	if (magic == NO_MAGIC)
 		return consumed;

--
2.41.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help