Re: [PATCH v7] submodule merge: update conflict error message

2 messages, 2 authors, 2022-08-02 · open the first message on its own page

Re: [PATCH v7] submodule merge: update conflict error message

From: Junio C Hamano <hidden>
Date: 2022-08-02 21:11:46

Calvin Wan [off-list ref] writes:
I'm thinking something like this:

"go to submodule ('sub' : 'a'), and either merge commit 'b'\n"
"go to submodule ('sub', 'a'), and either merge commit 'b'\n"
"go to submodule 'sub', commit 'a', and either merge commit 'b'\n"
In the first two, I suspect that it may not be quite clear what 'a'
means to the user.  In the third one, the first "commit" might be
mistaken as a verb.  I am tempted to say

    cd to <sub>, run "checkout --detach <a>" then "merge <b>"

but that may be a bit too prescriptive.  I dunno.


Re: [PATCH v7] submodule merge: update conflict error message

From: Calvin Wan <hidden>
Date: 2022-08-02 21:56:11

I'm starting to think this is getting out of scope for my patch.
For the errors, "not checked out" and "commits not present",
I will have a NEEDSWORK bit attached to them in
print_submodule_conflict(), and if any of the submodules has
those errors, then my message won't print out. That way,
we are guaranteed to have 'a' checked out when my message
prints, rendering it redundant.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help