Thread (6 messages) 6 messages, 4 authors, 2022-03-31

Re: [PATCH] worktree: add -z option for list subcommand

From: Phillip Wood <hidden>
Date: 2022-02-28 10:58:54

Hi Jean-Noël

On 28/02/2022 09:47, Jean-Noël Avila wrote:
Le 25/02/2022 à 16:08, Phillip Wood via GitGitGadget a écrit :
quoted
From: Phillip Wood <redacted>

@@ -696,6 +702,8 @@ static int list(int ac, const char **av, const 
char *prefix)
          usage_with_options(worktree_usage, options);
      else if (verbose && porcelain)
          die(_("options '%s' and '%s' cannot be used together"), 
"--verbose", "--porcelain");
+    else if (!line_terminator && !porcelain)
+        die(_("'-z' requires '--porcelain'"));
      else {
          struct worktree **worktrees = get_worktrees();
          int path_maxlen = 0, abbrev = DEFAULT_ABBREV, i;

Please better use

  die(_("the option '%s' requires '%s'"),  "-z", "--porcelain");


In order to make a no-op for translators.
Will do, thanks for the suggestion

Phillip
Best regards,

JN
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help